Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: tracing/tracing/ui/base/chart_base_2d.html

Issue 3017523002: Fix uses of /deep/ in trace viewer. (Closed)
Patch Set: fix tests Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/ui/base/chart_base.html ('k') | tracing/tracing/ui/base/dom_helpers.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/base/chart_base_2d.html
diff --git a/tracing/tracing/ui/base/chart_base_2d.html b/tracing/tracing/ui/base/chart_base_2d.html
index 13faa03fdcadda5c5f6b1fa3a60eb33dbac298a1..9ffe7fc55ae3fb74dc95c5e10e7c01f534adc132 100644
--- a/tracing/tracing/ui/base/chart_base_2d.html
+++ b/tracing/tracing/ui/base/chart_base_2d.html
@@ -13,16 +13,6 @@ found in the LICENSE file.
<link rel="import" href="/tracing/ui/base/chart_base.html">
<link rel="import" href="/tracing/ui/base/mouse_tracker.html">
-<style>
- * /deep/ .chart-base-2d.updating-brushing-state #brushes > * {
- fill: rgb(103, 199, 165)
- }
-
- * /deep/ .chart-base-2d #brushes {
- fill: rgb(213, 236, 229)
- }
-</style>
-
<script>
'use strict';
@@ -454,6 +444,11 @@ tr.exportTo('tr.ui.b', function() {
const chartAreaSel = d3.select(this.chartAreaElement);
this.updateXAxis_(chartAreaSel.select('.x.axis'));
this.updateYAxis_(chartAreaSel.select('.y.axis'));
+ for (const child of this.querySelectorAll('.axis path, .axis line')) {
+ child.style.fill = 'none';
+ child.style.shapeRendering = 'crispEdges';
+ child.style.stroke = 'black';
+ }
this.updateBrushContents_(chartAreaSel.select('#brushes'));
this.updateDataContents_(chartAreaSel.select('#series'));
},
@@ -538,6 +533,9 @@ tr.exportTo('tr.ui.b', function() {
Polymer.dom(this).classList.add('updating-brushing-state');
this.prepareDataEvent_(mouseEvent, dataEvent);
this.dispatchEvent(dataEvent);
+ for (const child of this.querySelectorAll('#brushes')) {
+ child.style.fill = 'rgb(103, 199, 165)';
+ }
},
onMouseMove_(button, mouseEvent) {
@@ -549,6 +547,9 @@ tr.exportTo('tr.ui.b', function() {
dataEvent.button = button;
this.prepareDataEvent_(mouseEvent, dataEvent);
this.dispatchEvent(dataEvent);
+ for (const child of this.querySelectorAll('#brushes')) {
+ child.style.fill = 'rgb(103, 199, 165)';
+ }
},
onMouseUp_(button, mouseEvent) {
@@ -559,6 +560,9 @@ tr.exportTo('tr.ui.b', function() {
this.prepareDataEvent_(mouseEvent, dataEvent);
this.dispatchEvent(dataEvent);
Polymer.dom(this).classList.remove('updating-brushing-state');
+ for (const child of this.querySelectorAll('#brushes')) {
+ child.style.fill = 'rgb(213, 236, 229)';
+ }
}
};
« no previous file with comments | « tracing/tracing/ui/base/chart_base.html ('k') | tracing/tracing/ui/base/dom_helpers.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698