Rename 'warmCache' to 'warm_cache'

telemetry/telemetry/page/cache_temperature.py

Index: telemetry/telemetry/page/cache_temperature.py
diff --git a/telemetry/telemetry/page/cache_temperature.py b/telemetry/telemetry/page/cache_temperature.py
index 093a388b957e28dcddf5b11648179e8ff91f4522..749ab864149ba1460d56e85b5ea6c352d785d299 100644
--- a/telemetry/telemetry/page/cache_temperature.py
+++ b/telemetry/telemetry/page/cache_temperature.py
@@ -62,14 +62,9 @@ def EnsurePageCacheTemperature(page, browser, previous_page=None):
     return
 
   if temperature == COLD:
-    if previous_page is None:
-      with MarkTelemetryInternal(browser, 'ensure_diskcache'):
-        tab = browser.tabs[0]
-        tab.Navigate("http://does.not.exist")

[nednguyen, 2017/09/19 09:40:27]

Wait, where is this logic not needed any more?

[yukiy, 2017/09/19 10:08:20]

This logic ensures that browser has any tab, but browser always has at least one
tab according to TabListBackend.
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

kouhei@ is this explanetion correct?

[nednguyen, 2017/09/19 10:25:00]

I recall it does more than that. Otherwise we wouldn't need the
"Navigate("http://does.not.exist")"

[yukiy, 2017/09/21 07:20:16]

Thanks ned, as you said this logic can't be removed.
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
So I want to do only renaming 'warmCache' to 'warm_cache' in this CL.

-        tab.WaitForDocumentReadyStateToBeComplete()
-
-    any_tab = browser.tabs[0]
-    any_tab.ClearCache(force=True)
+    with MarkTelemetryInternal(browser, 'clear_cache'):
+      any_tab = browser.tabs[0]
+      any_tab.ClearCache(force=True)
   elif temperature == WARM:
     if (previous_page is not None and
         previous_page.url == page.url and
@@ -86,7 +81,7 @@ def EnsurePageCacheTemperature(page, browser, previous_page=None):
           tab.WaitForDocumentReadyStateToBeComplete()
       return
 
-    with MarkTelemetryInternal(browser, 'warmCache'):
+    with MarkTelemetryInternal(browser, 'warm_cache'):
       tab = browser.tabs[0]
       tab.Navigate(page.url)
       py_utils.WaitFor(tab.HasReachedQuiescence, 60)