telemetry/telemetry/page/cache_temperature_unittest.py - Issue 3016563002: Rename 'warmCache' to 'warm_cache'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/cache_temperature_unittest.py

Issue 3016563002: Rename 'warmCache' to 'warm_cache' (Closed)

Patch Set: Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/page/cache_temperature_unittest.py

diff --git a/telemetry/telemetry/page/cache_temperature_unittest.py b/telemetry/telemetry/page/cache_temperature_unittest.py

index 2197fc460376aae2e090a906379ef3c76859c1bf..eed268c9eeaa26d530fe6325a29b556e9fd06b5a 100644

--- a/telemetry/telemetry/page/cache_temperature_unittest.py

+++ b/telemetry/telemetry/page/cache_temperature_unittest.py

@@ -49,8 +49,8 @@ class CacheTempeartureTests(browser_test_case.BrowserTestCase):

cache_temperature.EnsurePageCacheTemperature(page, self._browser)

markers = self.traceMarkers()

- self.assertNotIn('telemetry.internal.ensure_diskcache.start', markers)

- self.assertNotIn('telemetry.internal.warmCache.start', markers)

+ self.assertNotIn('telemetry.internal.clear_cache.start', markers)

+ self.assertNotIn('telemetry.internal.warm_cache.start', markers)

@decorators.Enabled('has tabs')

@decorators.Disabled('chromeos')

@@ -63,8 +63,8 @@ class CacheTempeartureTests(browser_test_case.BrowserTestCase):

cache_temperature.EnsurePageCacheTemperature(page, self._browser)

markers = self.traceMarkers()

- self.assertIn('telemetry.internal.ensure_diskcache.start', markers)

- self.assertIn('telemetry.internal.ensure_diskcache.end', markers)

+ self.assertIn('telemetry.internal.clear_cache.start', markers)

+ self.assertIn('telemetry.internal.clear_cache.end', markers)

@decorators.Enabled('has tabs')

def testEnsureWarmAfterColdRun(self):

@@ -83,7 +83,7 @@ class CacheTempeartureTests(browser_test_case.BrowserTestCase):

page, self._browser, previous_page)

markers = self.traceMarkers()

- self.assertNotIn('telemetry.internal.warmCache.start', markers)

+ self.assertNotIn('telemetry.internal.warm_cache.start', markers)

@decorators.Enabled('has tabs')

@decorators.Disabled('chromeos')

@@ -96,5 +96,5 @@ class CacheTempeartureTests(browser_test_case.BrowserTestCase):

cache_temperature.EnsurePageCacheTemperature(page, self._browser)

markers = self.traceMarkers()

- self.assertIn('telemetry.internal.warmCache.start', markers)

- self.assertIn('telemetry.internal.warmCache.end', markers)

+ self.assertIn('telemetry.internal.warm_cache.start', markers)

+ self.assertIn('telemetry.internal.warm_cache.end', markers)