Rename 'warmCache' to 'warm_cache'

telemetry/telemetry/page/cache_temperature.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Cache temperature specifies how the browser cache should be configured before
 the page run.
 
 See design doc for details:
 https://docs.google.com/document/u/1/d/12D7tkhZi887g9d0U2askU9JypU_wYiEI7Lw0bfwxUgA
@@ skipping 44 matching lines @@
     return True
 
 def EnsurePageCacheTemperature(page, browser, previous_page=None):
   temperature = page.cache_temperature
   logging.info('PageCacheTemperature: %s', temperature)
 
   if temperature == ANY:
     return
 
   if temperature == COLD:
-    if previous_page is None:
-      with MarkTelemetryInternal(browser, 'ensure_diskcache'):
-        tab = browser.tabs[0]
-        tab.Navigate("http://does.not.exist")

[nednguyen, 2017/09/19 09:40:27]

Wait, where is this logic not needed any more?

[yukiy, 2017/09/19 10:08:20]

This logic ensures that browser has any tab, but browser always has at least one
tab according to TabListBackend.
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

kouhei@ is this explanetion correct?

[nednguyen, 2017/09/19 10:25:00]

I recall it does more than that. Otherwise we wouldn't need the
"Navigate("http://does.not.exist")"

[yukiy, 2017/09/21 07:20:16]

Thanks ned, as you said this logic can't be removed.
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
So I want to do only renaming 'warmCache' to 'warm_cache' in this CL.

-        tab.WaitForDocumentReadyStateToBeComplete()
-
-    any_tab = browser.tabs[0]
-    any_tab.ClearCache(force=True)
+    with MarkTelemetryInternal(browser, 'clear_cache'):
+      any_tab = browser.tabs[0]
+      any_tab.ClearCache(force=True)
   elif temperature == WARM:
     if (previous_page is not None and
         previous_page.url == page.url and
         (previous_page.cache_temperature == COLD or
          previous_page.cache_temperature == WARM)):
       if '#' in page.url:
         # Navigate to inexistent URL to avoid in-page hash navigation.
         # Note: Unlike PCv1, PCv2 iterates the same URL for different cache
         #       configurations. This may issue blink in-page hash navigations,
         #       which isn't intended here.
         with MarkTelemetryInternal(browser, 'avoid_double_hash_navigation'):
           tab = browser.tabs[0]
           tab.Navigate("http://does.not.exist")
           tab.WaitForDocumentReadyStateToBeComplete()
       return
 
-    with MarkTelemetryInternal(browser, 'warmCache'):
+    with MarkTelemetryInternal(browser, 'warm_cache'):
       tab = browser.tabs[0]
       tab.Navigate(page.url)
       py_utils.WaitFor(tab.HasReachedQuiescence, 60)
       tab.WaitForDocumentReadyStateToBeComplete()
       tab.Navigate("about:blank")
       tab.WaitForDocumentReadyStateToBeComplete()