Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 301593002: DevTools: process events from all threads in TimelineTraceEventBindings (Closed)

Created:
6 years, 7 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: process events from all threads in TimelineTraceEventBindings We used to process only main thread events in both TraceEventBindings and TimelineFrameModel. This drops the filtering by thread from TracingModel and lets its clients process all events from the inspected target, performing filtering on their own. Also, this forks the enum for thread event names from that of timeline model -- they may occasionally overlap, but essentially these are two different enums. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174955

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 2

Patch Set 3 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -95 lines) Patch
M LayoutTests/inspector/layers/tracing-layer-tree.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/timeline/trace-event-self-time.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing-session-id.html View 2 chunks +8 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 3 chunks +22 lines, -9 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 3 chunks +8 lines, -4 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineTraceEventBindings.js View 1 5 chunks +109 lines, -11 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineTracingView.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingModel.js View 1 2 10 chunks +33 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
caseq
6 years, 7 months ago (2014-05-26 17:35:30 UTC) #1
caseq
6 years, 7 months ago (2014-05-27 14:45:08 UTC) #2
caseq
6 years, 7 months ago (2014-05-27 14:45:10 UTC) #3
yurys
lgtm https://codereview.chromium.org/301593002/diff/20001/Source/devtools/front_end/timeline/TracingModel.js File Source/devtools/front_end/timeline/TracingModel.js (right): https://codereview.chromium.org/301593002/diff/20001/Source/devtools/front_end/timeline/TracingModel.js#newcode91 Source/devtools/front_end/timeline/TracingModel.js:91: if (this._needToSortInspectedTargetEvents) { Can we just sort them ...
6 years, 7 months ago (2014-05-27 15:41:32 UTC) #4
caseq
On 2014/05/27 15:41:32, yurys wrote: > lgtm > > https://codereview.chromium.org/301593002/diff/20001/Source/devtools/front_end/timeline/TracingModel.js > File Source/devtools/front_end/timeline/TracingModel.js (right): > ...
6 years, 6 months ago (2014-05-28 08:48:40 UTC) #5
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-05-28 08:54:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/301593002/40001
6 years, 6 months ago (2014-05-28 08:54:13 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 10:14:21 UTC) #8
Message was sent while issue was closed.
Change committed as 174955

Powered by Google App Engine
This is Rietveld 408576698