Source/devtools/front_end/timeline/TimelineTracingView.js - Issue 301593002: DevTools: process events from all threads in TimelineTraceEventBindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineTracingView.js

Issue 301593002: DevTools: process events from all threads in TimelineTraceEventBindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments addressed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/timeline/TimelineTracingView.js

diff --git a/Source/devtools/front_end/timeline/TimelineTracingView.js b/Source/devtools/front_end/timeline/TimelineTracingView.js

index 8ab4e20914529554671aad9577a8196893fd31d1..96a2d8465980277e7ee1abc7e62622b9951d1a64 100644

--- a/Source/devtools/front_end/timeline/TimelineTracingView.js

+++ b/Source/devtools/front_end/timeline/TimelineTracingView.js

@@ -229,8 +229,8 @@ WebInspector.TraceViewFlameChartDataProvider = function(model, timelineModelForM

id: 0,

s: ""

}

- this._processHeaderRecord = new WebInspector.TracingModel.Event(dummyEventPayload, 0);

- this._threadHeaderRecord = new WebInspector.TracingModel.Event(dummyEventPayload, 0);

+ this._processHeaderRecord = new WebInspector.TracingModel.Event(dummyEventPayload, 0, null);

+ this._threadHeaderRecord = new WebInspector.TracingModel.Event(dummyEventPayload, 0, null);

}

WebInspector.TraceViewFlameChartDataProvider.prototype = {