Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 301593002: DevTools: process events from all threads in TimelineTraceEventBindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 301593002: DevTools: process events from all threads in TimelineTraceEventBindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments addressed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js

index 610b106aa8a44fdcc773171d99bb527992d60b37..39b7d608f3aae343738b799db1d23dd1be3061a2 100644

--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -553,9 +553,8 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {

this._currentLevel = 0;

this._minimumBoundary = this._model.minimumRecordTime() || 0;

this._timeSpan = Math.max((this._model.maximumRecordTime() || 0) - this._minimumBoundary, 1000000);

- var tracingModel = this._model;

this._appendHeaderRecord("CPU");

- var events = tracingModel.inspectedTargetMainThreadEvents();

+ var events = this._traceEventBindings.mainThreadEvents();

var maxStackDepth = 0;

for (var eventIndex = 0; eventIndex < events.length; ++eventIndex) {

var event = events[eventIndex];