Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 301423002: Add a way for the gpu veto to report back the reason why it said no (Closed)

Created:
6 years, 6 months ago by humper
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com, ernstm, nduca, ajuma, enne (OOO)
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add a way for the gpu veto to report back the reason why it said no BUG=2334 Committed: http://code.google.com/p/skia/source/detail?r=15012

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M include/core/SkPicture.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +10 lines, -3 lines 2 comments Download
M tests/PictureTest.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
humper
ptal
6 years, 6 months ago (2014-05-30 21:06:41 UTC) #1
bsalomon
On 2014/05/30 21:06:41, humper wrote: > ptal lgtm
6 years, 6 months ago (2014-05-30 21:19:59 UTC) #2
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-05-30 21:45:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/301423002/1
6 years, 6 months ago (2014-05-30 21:46:58 UTC) #4
commit-bot: I haz the power
Change committed as 15012
6 years, 6 months ago (2014-05-30 21:52:57 UTC) #5
ernstm
https://codereview.chromium.org/301423002/diff/1/src/core/SkPicture.cpp File src/core/SkPicture.cpp (right): https://codereview.chromium.org/301423002/diff/1/src/core/SkPicture.cpp#newcode667 src/core/SkPicture.cpp:667: if (this->numPaintWithPathEffectUses() < kNumPaintWithPathEffectUsesTol) Shouldn't this be >= ?
6 years, 6 months ago (2014-05-30 22:07:03 UTC) #6
robertphillips
6 years, 6 months ago (2014-06-02 13:22:15 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/301423002/diff/1/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/301423002/diff/1/src/core/SkPicture.cpp#newco...
src/core/SkPicture.cpp:665:
(this->numAAConcavePaths()-this->numAAHairlineConcavePaths()) <
kNumAAConcavePaths;
NULL != reason ?

Powered by Google App Engine
This is Rietveld 408576698