Add a way for the gpu veto to report back the reason why it said no

src/core/SkPicture.cpp

 
 /*
  * Copyright 2007 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkPictureFlat.h"
@@ skipping 636 matching lines @@
         // delete playback if it is a local version (i.e. cons'd up just now)
         if (playback != fPlayback) {
             SkDELETE(playback);
         }
     } else {
         buffer.writeBool(false);
     }
 }
 
 #if SK_SUPPORT_GPU
-bool SkPicture::suitableForGpuRasterization(GrContext* context) const {
+bool SkPicture::suitableForGpuRasterization(GrContext* context, const char **reason) const {
     // TODO: the heuristic used here needs to be refined
     static const int kNumPaintWithPathEffectUsesTol = 1;
     static const int kNumAAConcavePaths = 5;
 
     SkASSERT(this->numAAHairlineConcavePaths() <= this->numAAConcavePaths());
 
-    return this->numPaintWithPathEffectUses() < kNumPaintWithPathEffectUsesTol &&
-           (this->numAAConcavePaths()-this->numAAHairlineConcavePaths()) < kNumAAConcavePaths;
+    bool ret = this->numPaintWithPathEffectUses() < kNumPaintWithPathEffectUsesTol &&
+               (this->numAAConcavePaths()-this->numAAHairlineConcavePaths()) < kNumAAConcavePaths;

[robertphillips, 2014/06/02 13:22:16]

NULL != reason ?

+    if (!ret && reason) {
+        if (this->numPaintWithPathEffectUses() < kNumPaintWithPathEffectUsesTol)

[ernstm, 2014/05/30 22:07:04]

Shouldn't this be >= ?

+            *reason = "Too many path effects.";
+        else if ((this->numAAConcavePaths()-this->numAAHairlineConcavePaths()) < kNumAAConcavePaths)
+            *reason = "Too many anti-aliased concave paths.";
+    }
+    return ret;
 }
 #endif
 
 bool SkPicture::willPlayBackBitmaps() const {
     if (!fPlayback) {
         return false;
     }
     return fPlayback->containsBitmaps();
 }
 
@@ skipping 21 matching lines @@
     if (NULL != fRecord) {
         SkASSERT(NULL == fPlayback);
         return SK_InvalidGenID;
     }
 
     if (SK_InvalidGenID == fUniqueID) {
         fUniqueID = next_picture_generation_id();
     }
     return fUniqueID;
 }