Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: tests/PictureTest.cpp

Issue 301423002: Add a way for the gpu veto to report back the reason why it said no (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/core/SkPicture.cpp ('K') | « src/core/SkPicture.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PictureTest.cpp
diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp
index 1ef32abb95ee12986a4ddb65c4047d18cc4012b5..d27b4635838d2991886960864c7b921d293f52b5 100644
--- a/tests/PictureTest.cpp
+++ b/tests/PictureTest.cpp
@@ -730,7 +730,10 @@ static void test_gpu_veto(skiatest::Reporter* reporter) {
}
SkAutoTUnref<SkPicture> picture(recorder.endRecording());
// path effects currently render an SkPicture undesireable for GPU rendering
- REPORTER_ASSERT(reporter, !picture->suitableForGpuRasterization(NULL));
+
+ const char *reason = NULL;
+ REPORTER_ASSERT(reporter, !picture->suitableForGpuRasterization(NULL, &reason));
+ REPORTER_ASSERT(reporter, NULL != reason);
canvas = recorder.beginRecording(100, 100, NULL, 0);
{
« src/core/SkPicture.cpp ('K') | « src/core/SkPicture.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698