Refactor ThreadableLoaderOptions for readability

Refactor ThreadableLoaderOptions for readability

ThreadableLoaderOptions shouldn't derive from ResourceLoaderOptions.
ResourceLoaderOptions members are basically just passed through to
FetchRequest while items added by ThreadableLoaderOptions definition
are configuring how CORS, etc. are handled in ThreadableLoader.
Inheritance looks making things less readable to me.

Also, I'd like to make DocumentThreadbleLoader more readable by making
constant variables held by const members.

Items in ThreadableLoaderOptions that determines ThreadableLoader's
behavior could be held by DocumentThreadableLoader as a const member.
Items defined in ResourceLoaderOptions can be altered inside
DocumentThreadableLoader, but can still be held as a const member by
having members to hold overridden items.

BUG=377541
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175283

[tyoshino (SeeGerritForStatus), 2014-06-02 07:52:17]

Hi Kent-san, WDYT about this?

[tyoshino (SeeGerritForStatus), 2014-06-02 07:58:59]

After this change, I'll make loadRequest() take a ResourceLoaderOptions in
addition to ResourceRequest, and pass a ResourceLoaderOptions modified for
preflight in makeCrossOriginAccessControl() to fix the bug377541

[tkent, 2014-06-02 08:08:56]

lgtm

https://codereview.chromium.org/301243015/diff/40001/Source/core/fileapi/File...
File Source/core/fileapi/FileReaderLoader.cpp (right):

https://codereview.chromium.org/301243015/diff/40001/Source/core/fileapi/File...
Source/core/fileapi/FileReaderLoader.cpp:116: resourceLoaderOptions.sniffContent
= DoNotSniffContent;
This line is unnecessary.  DoNotSniffContent is the default value of
ResourceLoaderOptions::sniffContent.

https://codereview.chromium.org/301243015/diff/40001/Source/core/page/EventSo...
File Source/core/page/EventSource.cpp (right):

https://codereview.chromium.org/301243015/diff/40001/Source/core/page/EventSo...
Source/core/page/EventSource.cpp:145: resourceLoaderOptions.sniffContent =
DoNotSniffContent;
Ditto.

https://codereview.chromium.org/301243015/diff/40001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/301243015/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:846: resourceLoaderOptions.sniffContent =
DoNotSniffContent;
Ditto.

[tkent, 2014-06-02 08:10:05]

+japhet FYI

[tyoshino (SeeGerritForStatus), 2014-06-02 08:21:35]

https://codereview.chromium.org/301243015/diff/40001/Source/core/fileapi/File...
File Source/core/fileapi/FileReaderLoader.cpp (right):

https://codereview.chromium.org/301243015/diff/40001/Source/core/fileapi/File...
Source/core/fileapi/FileReaderLoader.cpp:116: resourceLoaderOptions.sniffContent
= DoNotSniffContent;
On 2014/06/02 08:08:56, tkent wrote:
> This line is unnecessary.  DoNotSniffContent is the default value of
> ResourceLoaderOptions::sniffContent.

Done.

https://codereview.chromium.org/301243015/diff/40001/Source/core/page/EventSo...
File Source/core/page/EventSource.cpp (right):

https://codereview.chromium.org/301243015/diff/40001/Source/core/page/EventSo...
Source/core/page/EventSource.cpp:145: resourceLoaderOptions.sniffContent =
DoNotSniffContent;
On 2014/06/02 08:08:56, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/301243015/diff/40001/Source/core/xml/XMLHttpR...
File Source/core/xml/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/301243015/diff/40001/Source/core/xml/XMLHttpR...
Source/core/xml/XMLHttpRequest.cpp:846: resourceLoaderOptions.sniffContent =
DoNotSniffContent;
On 2014/06/02 08:08:56, tkent wrote:
> Ditto.

Done.

[tyoshino (SeeGerritForStatus), 2014-06-02 08:21:41]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-06-02 08:21:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tyoshino@chromium.org/301243015/40015

[commit-bot: I haz the power, 2014-06-02 09:32:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[commit-bot: I haz the power, 2014-06-02 09:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-02 09:34:28]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[tyoshino (SeeGerritForStatus), 2014-06-02 10:36:47]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2014-06-02 10:37:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tyoshino@chromium.org/301243015/60001

[commit-bot: I haz the power, 2014-06-02 11:58:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[commit-bot: I haz the power, 2014-06-02 14:19:37]

Change committed as 175283