Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/core/loader/WorkerThreadableLoader.cpp

Issue 301243015: Refactor ThreadableLoaderOptions for readability (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/WorkerThreadableLoader.h ('k') | Source/core/page/EventSource.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 #include "platform/network/ResourceResponse.h" 44 #include "platform/network/ResourceResponse.h"
45 #include "platform/weborigin/Referrer.h" 45 #include "platform/weborigin/Referrer.h"
46 #include "public/platform/Platform.h" 46 #include "public/platform/Platform.h"
47 #include "public/platform/WebWaitableEvent.h" 47 #include "public/platform/WebWaitableEvent.h"
48 #include "wtf/MainThread.h" 48 #include "wtf/MainThread.h"
49 #include "wtf/OwnPtr.h" 49 #include "wtf/OwnPtr.h"
50 #include "wtf/Vector.h" 50 #include "wtf/Vector.h"
51 51
52 namespace WebCore { 52 namespace WebCore {
53 53
54 WorkerThreadableLoader::WorkerThreadableLoader(WorkerGlobalScope& workerGlobalSc ope, PassRefPtr<ThreadableLoaderClientWrapper> clientWrapper, PassOwnPtr<Threada bleLoaderClient> clientBridge, const ResourceRequest& request, const ThreadableL oaderOptions& options) 54 WorkerThreadableLoader::WorkerThreadableLoader(WorkerGlobalScope& workerGlobalSc ope, PassRefPtr<ThreadableLoaderClientWrapper> clientWrapper, PassOwnPtr<Threada bleLoaderClient> clientBridge, const ResourceRequest& request, const ThreadableL oaderOptions& options, const ResourceLoaderOptions& resourceLoaderOptions)
55 : m_workerGlobalScope(&workerGlobalScope) 55 : m_workerGlobalScope(&workerGlobalScope)
56 , m_workerClientWrapper(clientWrapper) 56 , m_workerClientWrapper(clientWrapper)
57 , m_bridge(*(new MainThreadBridge(m_workerClientWrapper, clientBridge, worke rGlobalScope.thread()->workerLoaderProxy(), request, options, workerGlobalScope. url().strippedForUseAsReferrer()))) 57 , m_bridge(*(new MainThreadBridge(m_workerClientWrapper, clientBridge, worke rGlobalScope.thread()->workerLoaderProxy(), request, options, resourceLoaderOpti ons, workerGlobalScope.url().strippedForUseAsReferrer())))
58 { 58 {
59 } 59 }
60 60
61 WorkerThreadableLoader::~WorkerThreadableLoader() 61 WorkerThreadableLoader::~WorkerThreadableLoader()
62 { 62 {
63 m_bridge.destroy(); 63 m_bridge.destroy();
64 } 64 }
65 65
66 void WorkerThreadableLoader::loadResourceSynchronously(WorkerGlobalScope& worker GlobalScope, const ResourceRequest& request, ThreadableLoaderClient& client, con st ThreadableLoaderOptions& options) 66 void WorkerThreadableLoader::loadResourceSynchronously(WorkerGlobalScope& worker GlobalScope, const ResourceRequest& request, ThreadableLoaderClient& client, con st ThreadableLoaderOptions& options, const ResourceLoaderOptions& resourceLoader Options)
67 { 67 {
68 blink::WebWaitableEvent* shutdownEvent = 68 blink::WebWaitableEvent* shutdownEvent =
69 workerGlobalScope.thread()->shutdownEvent(); 69 workerGlobalScope.thread()->shutdownEvent();
70 OwnPtr<blink::WebWaitableEvent> loaderDone = 70 OwnPtr<blink::WebWaitableEvent> loaderDone =
71 adoptPtr(blink::Platform::current()->createWaitableEvent()); 71 adoptPtr(blink::Platform::current()->createWaitableEvent());
72 72
73 Vector<blink::WebWaitableEvent*> events; 73 Vector<blink::WebWaitableEvent*> events;
74 events.append(shutdownEvent); 74 events.append(shutdownEvent);
75 events.append(loaderDone.get()); 75 events.append(loaderDone.get());
76 76
77 RefPtr<ThreadableLoaderClientWrapper> clientWrapper(ThreadableLoaderClientWr apper::create(&client)); 77 RefPtr<ThreadableLoaderClientWrapper> clientWrapper(ThreadableLoaderClientWr apper::create(&client));
78 OwnPtr<WorkerLoaderClientBridgeSyncHelper> clientBridge(WorkerLoaderClientBr idgeSyncHelper::create(client, loaderDone.release())); 78 OwnPtr<WorkerLoaderClientBridgeSyncHelper> clientBridge(WorkerLoaderClientBr idgeSyncHelper::create(client, loaderDone.release()));
79 79
80 // This must be valid while loader is around. 80 // This must be valid while loader is around.
81 WorkerLoaderClientBridgeSyncHelper* clientBridgePtr = clientBridge.get(); 81 WorkerLoaderClientBridgeSyncHelper* clientBridgePtr = clientBridge.get();
82 82
83 RefPtr<WorkerThreadableLoader> loader = WorkerThreadableLoader::create(worke rGlobalScope, clientWrapper, clientBridge.release(), request, options); 83 RefPtr<WorkerThreadableLoader> loader = WorkerThreadableLoader::create(worke rGlobalScope, clientWrapper, clientBridge.release(), request, options, resourceL oaderOptions);
84 84
85 blink::WebWaitableEvent* signalled; 85 blink::WebWaitableEvent* signalled;
86 { 86 {
87 ThreadState::SafePointScope scope(ThreadState::HeapPointersOnStack); 87 ThreadState::SafePointScope scope(ThreadState::HeapPointersOnStack);
88 signalled = blink::Platform::current()->waitMultipleEvents(events); 88 signalled = blink::Platform::current()->waitMultipleEvents(events);
89 } 89 }
90 if (signalled == shutdownEvent) { 90 if (signalled == shutdownEvent) {
91 loader->cancel(); 91 loader->cancel();
92 return; 92 return;
93 } 93 }
94 94
95 clientBridgePtr->run(); 95 clientBridgePtr->run();
96 } 96 }
97 97
98 void WorkerThreadableLoader::cancel() 98 void WorkerThreadableLoader::cancel()
99 { 99 {
100 m_bridge.cancel(); 100 m_bridge.cancel();
101 } 101 }
102 102
103 WorkerThreadableLoader::MainThreadBridge::MainThreadBridge( 103 WorkerThreadableLoader::MainThreadBridge::MainThreadBridge(
104 PassRefPtr<ThreadableLoaderClientWrapper> workerClientWrapper, 104 PassRefPtr<ThreadableLoaderClientWrapper> workerClientWrapper,
105 PassOwnPtr<ThreadableLoaderClient> clientBridge, 105 PassOwnPtr<ThreadableLoaderClient> clientBridge,
106 WorkerLoaderProxy& loaderProxy, 106 WorkerLoaderProxy& loaderProxy,
107 const ResourceRequest& request, const ThreadableLoaderOptions& options, cons t String& outgoingReferrer) 107 const ResourceRequest& request,
108 const ThreadableLoaderOptions& options,
109 const ResourceLoaderOptions& resourceLoaderOptions,
110 const String& outgoingReferrer)
108 : m_clientBridge(clientBridge) 111 : m_clientBridge(clientBridge)
109 , m_workerClientWrapper(workerClientWrapper) 112 , m_workerClientWrapper(workerClientWrapper)
110 , m_loaderProxy(loaderProxy) 113 , m_loaderProxy(loaderProxy)
111 { 114 {
112 ASSERT(m_workerClientWrapper.get()); 115 ASSERT(m_workerClientWrapper.get());
113 ASSERT(m_clientBridge.get()); 116 ASSERT(m_clientBridge.get());
114 m_loaderProxy.postTaskToLoader( 117 m_loaderProxy.postTaskToLoader(
115 createCallbackTask(&MainThreadBridge::mainThreadCreateLoader, 118 createCallbackTask(&MainThreadBridge::mainThreadCreateLoader, AllowCross ThreadAccess(this), request, options, resourceLoaderOptions, outgoingReferrer));
116 AllowCrossThreadAccess(this), request, options, outgo ingReferrer));
117 } 119 }
118 120
119 WorkerThreadableLoader::MainThreadBridge::~MainThreadBridge() 121 WorkerThreadableLoader::MainThreadBridge::~MainThreadBridge()
120 { 122 {
121 } 123 }
122 124
123 void WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader(ExecutionC ontext* context, MainThreadBridge* thisPtr, PassOwnPtr<CrossThreadResourceReques tData> requestData, ThreadableLoaderOptions options, const String& outgoingRefer rer) 125 void WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader(ExecutionC ontext* context, MainThreadBridge* thisPtr, PassOwnPtr<CrossThreadResourceReques tData> requestData, ThreadableLoaderOptions options, ResourceLoaderOptions resou rceLoaderOptions, const String& outgoingReferrer)
124 { 126 {
125 ASSERT(isMainThread()); 127 ASSERT(isMainThread());
126 Document* document = toDocument(context); 128 Document* document = toDocument(context);
127 129
128 OwnPtr<ResourceRequest> request(ResourceRequest::adopt(requestData)); 130 OwnPtr<ResourceRequest> request(ResourceRequest::adopt(requestData));
129 request->setHTTPReferrer(Referrer(outgoingReferrer, ReferrerPolicyDefault)); 131 request->setHTTPReferrer(Referrer(outgoingReferrer, ReferrerPolicyDefault));
130 options.requestInitiatorContext = WorkerContext; 132 resourceLoaderOptions.requestInitiatorContext = WorkerContext;
131 thisPtr->m_mainThreadLoader = DocumentThreadableLoader::create(*document, th isPtr, *request, options); 133 thisPtr->m_mainThreadLoader = DocumentThreadableLoader::create(*document, th isPtr, *request, options, resourceLoaderOptions);
132 if (!thisPtr->m_mainThreadLoader) { 134 if (!thisPtr->m_mainThreadLoader) {
133 // DocumentThreadableLoader::create may return 0 when the document loade r has been already changed. 135 // DocumentThreadableLoader::create may return 0 when the document loade r has been already changed.
134 thisPtr->didFail(ResourceError(errorDomainBlinkInternal, 0, request->url ().string(), "Can't create DocumentThreadableLoader")); 136 thisPtr->didFail(ResourceError(errorDomainBlinkInternal, 0, request->url ().string(), "Can't create DocumentThreadableLoader"));
135 } 137 }
136 } 138 }
137 139
138 void WorkerThreadableLoader::MainThreadBridge::mainThreadDestroy(ExecutionContex t* context, MainThreadBridge* thisPtr) 140 void WorkerThreadableLoader::MainThreadBridge::mainThreadDestroy(ExecutionContex t* context, MainThreadBridge* thisPtr)
139 { 141 {
140 ASSERT(isMainThread()); 142 ASSERT(isMainThread());
141 ASSERT_UNUSED(context, context->isDocument()); 143 ASSERT_UNUSED(context, context->isDocument());
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 { 224 {
223 m_clientBridge->didFailAccessControlCheck(error); 225 m_clientBridge->didFailAccessControlCheck(error);
224 } 226 }
225 227
226 void WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck() 228 void WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck()
227 { 229 {
228 m_clientBridge->didFailRedirectCheck(); 230 m_clientBridge->didFailRedirectCheck();
229 } 231 }
230 232
231 } // namespace WebCore 233 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/loader/WorkerThreadableLoader.h ('k') | Source/core/page/EventSource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698