Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/core/inspector/InspectorResourceAgent.cpp

Issue 301243015: Refactor ThreadableLoaderOptions for readability (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/fileapi/FileReaderLoader.cpp ('k') | Source/core/loader/DocumentThreadableLoader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 734 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 bool success = it->value->asString(&value); 745 bool success = it->value->asString(&value);
746 if (!success) { 746 if (!success) {
747 *errorString = "Request header \"" + it->key + "\" value is not a string"; 747 *errorString = "Request header \"" + it->key + "\" value is not a string";
748 return; 748 return;
749 } 749 }
750 request.addHTTPHeaderField(AtomicString(it->key), AtomicString(value )); 750 request.addHTTPHeaderField(AtomicString(it->key), AtomicString(value ));
751 } 751 }
752 } 752 }
753 753
754 ThreadableLoaderOptions options; 754 ThreadableLoaderOptions options;
755 options.allowCredentials = AllowStoredCredentials;
756 options.crossOriginRequestPolicy = AllowCrossOriginRequests; 755 options.crossOriginRequestPolicy = AllowCrossOriginRequests;
757 756
757 ResourceLoaderOptions resourceLoaderOptions;
758 resourceLoaderOptions.allowCredentials = AllowStoredCredentials;
759
758 InspectorThreadableLoaderClient* inspectorThreadableLoaderClient = new Inspe ctorThreadableLoaderClient(callback); 760 InspectorThreadableLoaderClient* inspectorThreadableLoaderClient = new Inspe ctorThreadableLoaderClient(callback);
759 RefPtr<DocumentThreadableLoader> loader = DocumentThreadableLoader::create(* document, inspectorThreadableLoaderClient, request, options); 761 RefPtr<DocumentThreadableLoader> loader = DocumentThreadableLoader::create(* document, inspectorThreadableLoaderClient, request, options, resourceLoaderOptio ns);
760 if (!loader) { 762 if (!loader) {
761 inspectorThreadableLoaderClient->didFailLoaderCreation(); 763 inspectorThreadableLoaderClient->didFailLoaderCreation();
762 return; 764 return;
763 } 765 }
764 loader->setDefersLoading(false); 766 loader->setDefersLoading(false);
765 if (!callback->isActive()) 767 if (!callback->isActive())
766 return; 768 return;
767 inspectorThreadableLoaderClient->setLoader(loader.release()); 769 inspectorThreadableLoaderClient->setLoader(loader.release());
768 } 770 }
769 771
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
813 InspectorResourceAgent::InspectorResourceAgent(InspectorPageAgent* pageAgent) 815 InspectorResourceAgent::InspectorResourceAgent(InspectorPageAgent* pageAgent)
814 : InspectorBaseAgent<InspectorResourceAgent>("Network") 816 : InspectorBaseAgent<InspectorResourceAgent>("Network")
815 , m_pageAgent(pageAgent) 817 , m_pageAgent(pageAgent)
816 , m_frontend(0) 818 , m_frontend(0)
817 , m_resourcesData(adoptPtr(new NetworkResourcesData())) 819 , m_resourcesData(adoptPtr(new NetworkResourcesData()))
818 , m_isRecalculatingStyle(false) 820 , m_isRecalculatingStyle(false)
819 { 821 {
820 } 822 }
821 823
822 } // namespace WebCore 824 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/fileapi/FileReaderLoader.cpp ('k') | Source/core/loader/DocumentThreadableLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698