dart2js kernel: Sort constants

dart2js kernel: Sort constants

[sra1, 2017-09-01 03:07:05]

sra@google.com changed reviewers:
+ johnniwinther@google.com

[sra1, 2017-09-01 03:07:06]

This is work in progress.

I still need to add an ordering for DartType.

[sra1, 2017-09-05 04:07:25]

PTAL

[Johnni Winther, 2017-09-05 07:19:56]

lgtm

https://codereview.chromium.org/3011803002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/constant_ordering.dart (right):

https://codereview.chromium.org/3011803002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/constant_ordering.dart:104: return
_compareResolutionDartTypes(a, b);
Can't we use _dartTypeOrdering for ResolutionDartType? When are they different?

[sra1, 2017-09-05 18:30:22]

https://codereview.chromium.org/3011803002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/constant_ordering.dart (right):

https://codereview.chromium.org/3011803002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/constant_ordering.dart:104: return
_compareResolutionDartTypes(a, b);
On 2017/09/05 07:19:56, Johnni Winther wrote:
> Can't we use _dartTypeOrdering for ResolutionDartType? When are they
different?

print(const Foo<String>());
print(const Foo<UnresolvedType>());

causes comparison on a malformed type which are not visible through the DartType
hierarchy.
We will eventually make this an error.

[Johnni Winther, 2017-09-06 07:16:48]

https://codereview.chromium.org/3011803002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/constant_ordering.dart (right):

https://codereview.chromium.org/3011803002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/constant_ordering.dart:104: return
_compareResolutionDartTypes(a, b);
On 2017/09/05 18:30:21, sra1 wrote:
> On 2017/09/05 07:19:56, Johnni Winther wrote:
> > Can't we use _dartTypeOrdering for ResolutionDartType? When are they
> different?
> 
> print(const Foo<String>());
> print(const Foo<UnresolvedType>());
> 
> causes comparison on a malformed type which are not visible through the
DartType
> hierarchy.
> We will eventually make this an error.

Acknowledged.