Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/sorter.dart

Issue 3011803002: dart2js kernel: Sort constants
Patch Set: implement DartType ordering Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_emitter.sorter; 5 library dart2js.js_emitter.sorter;
6 6
7 import '../elements/elements.dart'; 7 import '../elements/elements.dart';
8 import '../elements/entities.dart'; 8 import '../elements/entities.dart';
9 9
10 /// Sorting strategy for libraries, classes and members. 10 /// Sorting strategy for libraries, classes and members.
11 abstract class Sorter { 11 abstract class Sorter {
12 /// Returns a sorted list of [libraries]. 12 /// Returns a sorted list of [libraries].
13 Iterable<LibraryEntity> sortLibraries(Iterable<LibraryEntity> libraries); 13 Iterable<LibraryEntity> sortLibraries(Iterable<LibraryEntity> libraries);
14 14
15 /// Returns a sorted list of [classes]. 15 /// Returns a sorted list of [classes].
16 Iterable<ClassEntity> sortClasses(Iterable<ClassEntity> classes); 16 Iterable<ClassEntity> sortClasses(Iterable<ClassEntity> classes);
17 17
18 /// Returns a sorted list of [typedefs]. 18 /// Returns a sorted list of [typedefs].
19 Iterable<TypedefEntity> sortTypedefs(Iterable<TypedefEntity> typedefs); 19 Iterable<TypedefEntity> sortTypedefs(Iterable<TypedefEntity> typedefs);
20 20
21 /// Returns a sorted list of [members]. 21 /// Returns a sorted list of [members].
22 Iterable<MemberEntity> sortMembers(Iterable<MemberEntity> members); 22 Iterable<MemberEntity> sortMembers(Iterable<MemberEntity> members);
23
24 int compareLibrariesByLocation(LibraryEntity a, LibraryEntity b);
25 int compareClassesByLocation(ClassEntity a, ClassEntity b);
26 int compareTypedefsByLocation(TypedefEntity a, TypedefEntity b);
27 int compareMembersByLocation(MemberEntity a, MemberEntity b);
23 } 28 }
24 29
25 class ElementSorter implements Sorter { 30 class ElementSorter implements Sorter {
26 const ElementSorter(); 31 const ElementSorter();
27 32
28 @override 33 @override
29 List<LibraryEntity> sortLibraries(Iterable<LibraryEntity> libraries) { 34 List<LibraryEntity> sortLibraries(Iterable<LibraryEntity> libraries) {
30 return Elements.sortedByPosition(new List.from(libraries, growable: false)); 35 return Elements.sortedByPosition(new List.from(libraries, growable: false));
31 } 36 }
32 37
(...skipping 21 matching lines...) Expand all
54 59
55 @override 60 @override
56 Iterable<TypedefEntity> sortTypedefs(Iterable<TypedefEntity> typedefs) { 61 Iterable<TypedefEntity> sortTypedefs(Iterable<TypedefEntity> typedefs) {
57 return Elements.sortedByPosition(new List.from(typedefs, growable: false)); 62 return Elements.sortedByPosition(new List.from(typedefs, growable: false));
58 } 63 }
59 64
60 @override 65 @override
61 List<MemberEntity> sortMembers(Iterable<MemberEntity> members) { 66 List<MemberEntity> sortMembers(Iterable<MemberEntity> members) {
62 return Elements.sortedByPosition(new List.from(members, growable: false)); 67 return Elements.sortedByPosition(new List.from(members, growable: false));
63 } 68 }
69
70 @override
71 int compareLibrariesByLocation(
72 covariant LibraryElement a, covariant LibraryElement b) =>
73 Elements.compareByPosition(a, b);
74
75 @override
76 int compareClassesByLocation(
77 covariant ClassElement a, covariant ClassElement b) =>
78 Elements.compareByPosition(a, b);
79
80 @override
81 int compareTypedefsByLocation(
82 covariant TypedefElement a, covariant TypedefElement b) =>
83 Elements.compareByPosition(a, b);
84
85 @override
86 int compareMembersByLocation(
87 covariant MemberElement a, covariant MemberElement b) =>
88 Elements.compareByPosition(a, b);
64 } 89 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698