Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: pkg/compiler/lib/src/js_emitter/sorter.dart

Issue 3011803002: dart2js kernel: Sort constants
Patch Set: implement DartType ordering Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/sorter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/sorter.dart b/pkg/compiler/lib/src/js_emitter/sorter.dart
index 3b99320bd1a725a81b6a6975d056558f12bcbfbf..d3cfff6a5f9ebeb7cd999eb3b70bb981e686573b 100644
--- a/pkg/compiler/lib/src/js_emitter/sorter.dart
+++ b/pkg/compiler/lib/src/js_emitter/sorter.dart
@@ -20,6 +20,11 @@ abstract class Sorter {
/// Returns a sorted list of [members].
Iterable<MemberEntity> sortMembers(Iterable<MemberEntity> members);
+
+ int compareLibrariesByLocation(LibraryEntity a, LibraryEntity b);
+ int compareClassesByLocation(ClassEntity a, ClassEntity b);
+ int compareTypedefsByLocation(TypedefEntity a, TypedefEntity b);
+ int compareMembersByLocation(MemberEntity a, MemberEntity b);
}
class ElementSorter implements Sorter {
@@ -61,4 +66,24 @@ class ElementSorter implements Sorter {
List<MemberEntity> sortMembers(Iterable<MemberEntity> members) {
return Elements.sortedByPosition(new List.from(members, growable: false));
}
+
+ @override
+ int compareLibrariesByLocation(
+ covariant LibraryElement a, covariant LibraryElement b) =>
+ Elements.compareByPosition(a, b);
+
+ @override
+ int compareClassesByLocation(
+ covariant ClassElement a, covariant ClassElement b) =>
+ Elements.compareByPosition(a, b);
+
+ @override
+ int compareTypedefsByLocation(
+ covariant TypedefElement a, covariant TypedefElement b) =>
+ Elements.compareByPosition(a, b);
+
+ @override
+ int compareMembersByLocation(
+ covariant MemberElement a, covariant MemberElement b) =>
+ Elements.compareByPosition(a, b);
}

Powered by Google App Engine
This is Rietveld 408576698