[pinpoint] Docstrings for models/change/repository.py.

[pinpoint] Docstrings for models/change/repository.py.

Followup for https://codereview.chromium.org/3013683002/.

Review-Url: https://chromiumcodereview.appspot.com/3011393002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/852ba7672ce02911e9f8f2a22363283adc80940e

[dtu, 2017-09-22 20:15:39]

dtu@chromium.org changed reviewers:
+ perezju@chromium.org, simonhatch@chromium.org, sullivan@chromium.org

[shatch, 2017-09-22 21:37:55]

lgtm

[perezju, 2017-09-25 09:28:44]

lgtm w/nits

Thanks!

https://codereview.chromium.org/3011393002/diff/1/dashboard/dashboard/pinpoin...
File dashboard/dashboard/pinpoint/models/change/repository.py (right):

https://codereview.chromium.org/3011393002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/change/repository.py:16: have multiple URLs.
The returned URL should be the most canonical one.
nit: "most canonical" -> "current canonical" ? (not entirely sure if it reads
better)

https://codereview.chromium.org/3011393002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/change/repository.py:45: the most canonical
URL, so old URLs are automatically "upconverted".
ditto

[dtu, 2017-09-25 20:35:10]

https://codereview.chromium.org/3011393002/diff/1/dashboard/dashboard/pinpoin...
File dashboard/dashboard/pinpoint/models/change/repository.py (right):

https://codereview.chromium.org/3011393002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/change/repository.py:16: have multiple URLs.
The returned URL should be the most canonical one.
On 2017/09/25 09:28:43, perezju wrote:
> nit: "most canonical" -> "current canonical" ? (not entirely sure if it reads
> better)

Done.

https://codereview.chromium.org/3011393002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/change/repository.py:45: the most canonical
URL, so old URLs are automatically "upconverted".
On 2017/09/25 09:28:43, perezju wrote:
> ditto

Done.

[dtu, 2017-09-25 20:35:14]

The CQ bit was checked by dtu@chromium.org

[dtu, 2017-09-25 20:35:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
perezju@chromium.org, simonhatch@chromium.org
Link to the patchset: https://codereview.chromium.org/3011393002/#ps20001
(title: ""current canonical"")

[commit-bot: I haz the power, 2017-09-25 20:35:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-25 21:53:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1506371714239890,
"parent_rev": "41b2ba3a995ec28b1d7aa6b04b88cb0a348d9ccd", "commit_rev":
"852ba7672ce02911e9f8f2a22363283adc80940e"}

[commit-bot: I haz the power, 2017-09-25 21:53:24]

Description was changed from

==========
[pinpoint] Docstrings for models/change/repository.py.

Followup for https://codereview.chromium.org/3013683002/.
==========

to

==========
[pinpoint] Docstrings for models/change/repository.py.

Followup for https://codereview.chromium.org/3013683002/.

Review-Url: https://chromiumcodereview.appspot.com/3011393002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-25 21:53:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...