dashboard/dashboard/pinpoint/models/job.py - Issue 3011393002: [pinpoint] Docstrings for models/change/repository.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/pinpoint/models/job.py

Issue 3011393002: [pinpoint] Docstrings for models/change/repository.py. (Closed)

Patch Set: "current canonical" Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dashboard/dashboard/pinpoint/models/job.py

diff --git a/dashboard/dashboard/pinpoint/models/job.py b/dashboard/dashboard/pinpoint/models/job.py

index ebf63e87faf650f7860733b40877baa3f18b2c66..0228a25d29fec33e491cda5532ffae0f35c92518 100644

--- a/dashboard/dashboard/pinpoint/models/job.py

+++ b/dashboard/dashboard/pinpoint/models/job.py

@@ -249,6 +249,7 @@ class _JobState(object):

there's no way to pick additional Changes to try.

"""

# This loop adds Changes to the _changes list while looping through it.

+ # The Change insertion simultaneously uses and modifies the list indices.

# However, the loop index goes in reverse order and Changes are only added

# after the loop index, so the loop never encounters the modified items.

for index, change_b in reversed(tuple(self.Differences())):

« no previous file with comments | « dashboard/dashboard/pinpoint/models/change/repository.py ('k') | no next file » | no next file with comments »