Add language_2 tests demonstrating bug #30568

Add language_2 tests demonstrating bug #30568

R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/b8e54ea4181c632a11a5c9c97fcd11d1beccb9a5

[Paul Berry, 2017-08-29 20:48:58]

paulberry@google.com changed reviewers:
+ lrn@google.com, rnystrom@google.com

[Bob Nystrom, 2017-08-29 21:55:08]

Oh, dang, that's a nasty edge case.

Thanks for the nicely documented tests!

LGTM++

[Paul Berry, 2017-08-29 22:09:27]

Description was changed from

==========
Add language_2 tests demonstrating bug #30568
==========

to

==========
Add language_2 tests demonstrating bug #30568

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b8e54ea4181c632a11a5c9c97fcd11d1beccb9a5
==========

[Paul Berry, 2017-08-29 22:09:28]

Committed patchset #1 (id:1) manually as
b8e54ea4181c632a11a5c9c97fcd11d1beccb9a5 (presubmit successful).

[Lasse Reichstein Nielsen, 2017-08-30 06:00:42]

Also consider the case:

abstract class I { void foo([x]); }
class B implements I {
  foo(x) => x;
}

It might be covered elsewhere, because it's just a bad override.

LGTM

https://codereview.chromium.org/3008823002/diff/1/tests/language_2/additional...
File tests/language_2/additional_interface_adds_optional_args_test.dart (right):

https://codereview.chromium.org/3008823002/diff/1/tests/language_2/additional...
tests/language_2/additional_interface_adds_optional_args_test.dart:26:
super.foo();
Have tests that do `super.foo(x)` as well, and see that the are disallowed.

[Paul Berry, 2017-08-30 20:08:25]

https://codereview.chromium.org/3008823002/diff/1/tests/language_2/additional...
File tests/language_2/additional_interface_adds_optional_args_test.dart (right):

https://codereview.chromium.org/3008823002/diff/1/tests/language_2/additional...
tests/language_2/additional_interface_adds_optional_args_test.dart:26:
super.foo();
On 2017/08/30 06:00:42, Lasse Reichstein Nielsen wrote:
> Have tests that do `super.foo(x)` as well, and see that the are disallowed.

Good call.  There are bugs related to this too.

Additional tests here: https://codereview.chromium.org/3005893002/