Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 3005893002: Additional test cases related to bug #30568 (Closed)

Created:
3 years, 3 months ago by Paul Berry
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Additional test cases related to bug #30568 These test cases verify that when a method calls super, compile-time arity checks are performed against the actual target of super, rather than the interface exposed by the base class. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/991ea77f32018ae0935cc223778329338d8b7172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
A tests/language_2/abstract_override_adds_optional_args_supercall_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A tests/language_2/additional_interface_adds_optional_args_supercall_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M tests/language_2/language_2_analyzer.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language_2/language_2_dartdevc.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language_2/language_2_precompiled.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language_2/language_2_vm.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
3 years, 3 months ago (2017-08-30 20:07:55 UTC) #2
Lasse Reichstein Nielsen
LGTM! The super-mixin problem also touches this issue, but at least that's not in the ...
3 years, 3 months ago (2017-08-31 07:50:58 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 991ea77f32018ae0935cc223778329338d8b7172 (presubmit successful).
3 years, 3 months ago (2017-08-31 17:10:04 UTC) #5
Paul Berry
On 2017/08/31 07:50:58, Lasse Reichstein Nielsen wrote: > LGTM! > > The super-mixin problem also ...
3 years, 3 months ago (2017-08-31 21:15:14 UTC) #6
Paul Berry
3 years, 3 months ago (2017-09-06 16:06:38 UTC) #7
Message was sent while issue was closed.
On 2017/08/31 21:15:14, Paul Berry wrote:
> On 2017/08/31 07:50:58, Lasse Reichstein Nielsen wrote:
> > LGTM!
> > 
> > The super-mixin problem also touches this issue, but at least that's not in
> the
> > 2.0 spec, so it only affects our Flutter-compatibility flag.
> 
> I would love to add some tests to cover the super-mixin case as well.  Do you
> know where tests of super-mixin functionality should go?

ping

Powered by Google App Engine
This is Rietveld 408576698