Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(727)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: tests/language_2/additional_interface_adds_optional_args_concrete_test.dart
Issue
3008823002
:
Add language_2 tests demonstrating bug #30568 (Closed)
Patch Set:
Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
tests/language_2/abstract_override_adds_optional_args_concrete_subclass_test.dart
tests/language_2/abstract_override_adds_optional_args_concrete_test.dart
tests/language_2/abstract_override_adds_optional_args_test.dart
tests/language_2/additional_interface_adds_optional_args_concrete_subclass_test.dart
tests/language_2/additional_interface_adds_optional_args_concrete_test.dart
tests/language_2/additional_interface_adds_optional_args_test.dart
tests/language_2/language_2_analyzer.status
tests/language_2/language_2_dart2js.status
tests/language_2/language_2_dartdevc.status
tests/language_2/language_2_precompiled.status
tests/language_2/language_2_vm.status
View unified diff
|
Download patch
« no previous file with comments
|
« tests/language_2/additional_interface_adds_optional_args_concrete_subclass_test.dart
('k') |
tests/language_2/additional_interface_adds_optional_args_test.dart »
('j') |
tests/language_2/additional_interface_adds_optional_args_test.dart »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2
// for details. All rights reserved. Use of this source code is governed by a
3
// BSD-style license that can be found in the LICENSE file.
4
5
class A {
6
void foo() {}
7
}
8
9
abstract class I {
10
void foo([x]);
11
}
12
13
class /*@compile-error=unspecified*/ B extends A implements I {
14
// This class declaration violates soundness, since it allows `new
15
// B().foo(42)`, which would lead to invalid arguments being passed to A.foo.
16
}
17
18
void f(B b) {
19
b.foo();
20
}
21
22
main() {
23
f(new B());
24
}
OLD
NEW
« no previous file with comments
|
« tests/language_2/additional_interface_adds_optional_args_concrete_subclass_test.dart
('k') |
tests/language_2/additional_interface_adds_optional_args_test.dart »
('j') |
tests/language_2/additional_interface_adds_optional_args_test.dart »
('J')
Issue 3008823002: Add language_2 tests demonstrating bug #30568 (Closed)
Created 3 years, 3 months ago by Paul Berry
Modified 3 years, 3 months ago
Reviewers: Bob Nystrom, Lasse Reichstein Nielsen
Base URL:
Comments: 2
This is Rietveld
408576698