[Telemetry] Expose disable_stories in StoryExpectations api.

[Telemetry] Expose disable_stories in StoryExpectations api.

Some consumers might want to see the list of disabled stories for a given benchmark.
An example of this would be writing a script that listed all disabled stories for
a given benchmark.

BUG=chromium:723636
Review-Url: https://chromiumcodereview.appspot.com/3008203003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7e64a932ba85aaef91770bab0e2649ed241fcdff

[rnephew (Reviews Here), 2017-09-07 16:50:28]

rnephew@chromium.org changed reviewers:
+ charliea@chromium.org, nednguyen@google.com

[rnephew (Reviews Here), 2017-09-07 18:28:50]

The CQ bit was checked by rnephew@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-07 18:28:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-07 18:55:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-07 18:55:28]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-09-07 21:43:22]

https://codereview.chromium.org/3008203003/diff/1/telemetry/telemetry/story/e...
File telemetry/telemetry/story/expectations.py (right):

https://codereview.chromium.org/3008203003/diff/1/telemetry/telemetry/story/e...
telemetry/telemetry/story/expectations.py:28: def disabled_stories(self):
the name here "disabled_stories" but then this returns "_expectations". Can you
think of better naming for the method? Also this needs documentation to explain
the data type of the return value.

[rnephew (Reviews Here), 2017-09-11 17:31:55]

https://codereview.chromium.org/3008203003/diff/1/telemetry/telemetry/story/e...
File telemetry/telemetry/story/expectations.py (right):

https://codereview.chromium.org/3008203003/diff/1/telemetry/telemetry/story/e...
telemetry/telemetry/story/expectations.py:28: def disabled_stories(self):
On 2017/09/07 21:43:21, nednguyen wrote:
> the name here "disabled_stories" but then this returns "_expectations". Can
you
> think of better naming for the method? Also this needs documentation to
explain
> the data type of the return value.

Switched to calling it AsDict() as recomended by Juan in
https://chromium-review.googlesource.com/c/chromium/src/+/655361

[nednguyen, 2017-09-11 17:33:52]

lgtm

[rnephew (Reviews Here), 2017-09-11 17:34:29]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2017-09-11 17:34:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-11 18:44:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505151269652850,
"parent_rev": "99ec8187805e3ab807dac86c1ef0a1b07be9d1a6", "commit_rev":
"7e64a932ba85aaef91770bab0e2649ed241fcdff"}

[commit-bot: I haz the power, 2017-09-11 18:44:33]

Description was changed from

==========
[Telemetry] Expose disable_stories in StoryExpectations api.

Some consumers might want to see the list of disabled stories for a given
benchmark.
An example of this would be writing a script that listed all disabled stories
for
a given benchmark.

BUG=chromium:723636
==========

to

==========
[Telemetry] Expose disable_stories in StoryExpectations api.

Some consumers might want to see the list of disabled stories for a given
benchmark.
An example of this would be writing a script that listed all disabled stories
for
a given benchmark.

BUG=chromium:723636

Review-Url: https://chromiumcodereview.appspot.com/3008203003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-11 18:44:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...