[Telemetry] Expose disable_stories in StoryExpectations api.

telemetry/telemetry/story/expectations.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 
 class StoryExpectations(object):
   """An object that contains disabling expectations for benchmarks and stories.
 
   Example Usage:
   class FooBenchmarkExpectations(expectations.StoryExpectations):
     def SetExpectations(self):
       self.DisableBenchmark(
           [expectations.ALL_MOBILE], 'Desktop Benchmark')
       self.DisableStory('story_name1', [expectations.ALL_MAC], 'crbug.com/456')
       self.DisableStory('story_name2', [expectations.ALL], 'crbug.com/789')
       ...
   """
   def __init__(self):
     self._disabled_platforms = []
     self._expectations = {}
     self._frozen = False
     self.SetExpectations()
     self._Freeze()
 
+  @property
+  def disabled_stories(self):

[nednguyen, 2017/09/07 21:43:21]

the name here "disabled_stories" but then this returns "_expectations". Can you
think of better naming for the method? Also this needs documentation to explain
the data type of the return value.

[rnephew (Reviews Here), 2017/09/11 17:31:55]

Switched to calling it AsDict() as recomended by Juan in
https://chromium-review.googlesource.com/c/chromium/src/+/655361

+    return self._expectations
+
   def GetBrokenExpectations(self, story_set):
     story_set_story_names = [s.name for s in story_set.stories]
     invalid_story_names = []
     for story_name in self._expectations:
       if story_name not in story_set_story_names:
         invalid_story_names.append(story_name)
         logging.error('Story %s is not in the story set.' % story_name)
     return invalid_story_names
 
   def SetExpectations(self):
@@ skipping 219 matching lines @@
 #   Mac 10.11 Perf, Mac Retina Perf, Mac Pro 10.11 Perf, Mac Air 10.11 Perf
 MAC_10_11 = _TestConditionByMacVersion('10.11', 'Mac 10.11')
 # Mac 10_12 Includes:
 #   Mac 10.12 Perf, Mac Mini 8GB 10.12 Perf
 MAC_10_12 = _TestConditionByMacVersion('10.12', 'Mac 10.12')
 
 ANDROID_NEXUS6_WEBVIEW = _TestConditionLogicalAndConditions(
     [ANDROID_NEXUS6, ANDROID_WEBVIEW], 'Nexus6 Webview')
 ANDROID_NEXUS5X_WEBVIEW = _TestConditionLogicalAndConditions(
     [ANDROID_NEXUS5X, ANDROID_WEBVIEW], 'Nexus5X Webview')