Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: pkg/front_end/test/token_test.dart

Issue 3007943002: gracefully recover from extraneous top level modifiers (Closed)
Patch Set: revise parseTopLevelDeclaration and address comments Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/messages.yaml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/test/token_test.dart
diff --git a/pkg/front_end/test/token_test.dart b/pkg/front_end/test/token_test.dart
index 61cffe5239b958dac12338fc61b8fe08ab0ca362..a128358bdd7c774cfa2c297d2e0be6c72b72271b 100644
--- a/pkg/front_end/test/token_test.dart
+++ b/pkg/front_end/test/token_test.dart
@@ -172,6 +172,45 @@ class Foo {
}
}
+ void test_isModifier() {
+ var modifierKeywords = new Set<Keyword>.from([
+ Keyword.ABSTRACT,
+ Keyword.CONST,
+ Keyword.FINAL,
+ Keyword.STATIC,
+ ]);
+ for (Keyword keyword in Keyword.values) {
+ var isModifier = modifierKeywords.contains(keyword);
+ var scanner = new StringScanner(keyword.lexeme, includeComments: true);
+ Token token = scanner.tokenize();
+ expect(token.isModifier, isModifier, reason: keyword.name);
+ if (isModifier) {
+ expect(token.isTopLevelKeyword, isFalse, reason: keyword.name);
+ }
+ }
+ }
+
+ void test_isTopLevelKeyword() {
+ var topLevelKeywords = new Set<Keyword>.from([
+ Keyword.CLASS,
+ Keyword.ENUM,
+ Keyword.EXPORT,
+ Keyword.IMPORT,
+ Keyword.LIBRARY,
+ Keyword.PART,
+ Keyword.TYPEDEF,
+ ]);
+ for (Keyword keyword in Keyword.values) {
+ var isTopLevelKeyword = topLevelKeywords.contains(keyword);
+ var scanner = new StringScanner(keyword.lexeme, includeComments: true);
+ Token token = scanner.tokenize();
+ expect(token.isTopLevelKeyword, isTopLevelKeyword, reason: keyword.name);
+ if (isTopLevelKeyword) {
+ expect(token.isModifier, isFalse, reason: keyword.name);
+ }
+ }
+ }
+
void test_pseudo_keywords() {
var pseudoKeywords = new Set<Keyword>.from([
Keyword.ASYNC,
« no previous file with comments | « pkg/front_end/messages.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698