gracefully recover from extraneous top level modifiers

pkg/analyzer/test/generated/parser_fasta_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart' as analyzer;
 import 'package:analyzer/dart/ast/token.dart' show TokenType;
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/error/listener.dart' show ErrorReporter;
 import 'package:analyzer/src/dart/scanner/scanner.dart';
@@ skipping 179 matching lines @@
     // TODO(brianwilkerson) Does not recover.
     super.test_constAndVar();
   }
 
   @override
   @failingTest
   void test_constClass() {
     // TODO(brianwilkerson) Wrong errors:
     // Expected 1 errors of type ParserErrorCode.CONST_CLASS, found 0;
     // 0 errors of type ParserErrorCode.EXTRANEOUS_MODIFIER, found 2 (1, 7)
+
+    // TODO(danrubel): Rather than reporting ParserErrorCode.EXTRANEOUS_MODIFIER
+    // report ParserErrorCode.CONST_CLASS to better help the user
     super.test_constClass();
   }
 
   @override
   @failingTest
   void test_constConstructorWithBody() {
     // TODO(brianwilkerson) Wrong errors:
     // Expected 1 errors of type ParserErrorCode.CONST_CONSTRUCTOR_WITH_BODY, found 0
     super.test_constConstructorWithBody();
   }
 
   @override
   @failingTest
-  void test_constEnum() {
-    // TODO(brianwilkerson) Wrong errors:
-    // Expected 1 errors of type ParserErrorCode.CONST_ENUM, found 0;
-    // 0 errors of type ParserErrorCode.EXTRANEOUS_MODIFIER, found 2 (1, 7)
-    super.test_constEnum();
-  }
-
-  @override
-  @failingTest
   void test_constFactory() {
     // TODO(brianwilkerson) Wrong errors:
     // Expected 1 errors of type ParserErrorCode.CONST_FACTORY, found 0
     super.test_constFactory();
   }
 
   @override
   @failingTest
   void test_constMethod() {
     // TODO(brianwilkerson) Wrong errors:
@@ skipping 13 matching lines @@
   @failingTest
   void test_constructorWithReturnType_var() {
     // TODO(brianwilkerson) Wrong errors:
     // Expected 1 errors of type ParserErrorCode.CONSTRUCTOR_WITH_RETURN_TYPE, found 0;
     // 0 errors of type ParserErrorCode.EXTRANEOUS_MODIFIER, found 1 (0)
     super.test_constructorWithReturnType_var();
   }
 
   @override
   @failingTest
-  void test_constTypedef() {
-    // TODO(brianwilkerson) Wrong errors:
-    // Expected 1 errors of type ParserErrorCode.CONST_TYPEDEF, found 0;
-    // 0 errors of type ParserErrorCode.EXTRANEOUS_MODIFIER, found 2 (1, 7)
-    super.test_constTypedef();
-  }
-
-  @override
-  @failingTest
   void test_continueOutsideOfLoop_continueInIfStatement() {
     // TODO(brianwilkerson) Wrong errors:
     // Expected 1 errors of type ParserErrorCode.CONTINUE_OUTSIDE_OF_LOOP, found 0
     super.test_continueOutsideOfLoop_continueInIfStatement();
   }
 
   @override
   @failingTest
   void test_continueOutsideOfLoop_functionExpression_inALoop() {
     // TODO(brianwilkerson) Wrong errors:
@@ skipping 507 matching lines @@
   }
 
   @override
   @failingTest
   void test_finalAndVar() {
     super.test_finalAndVar();
   }
 
   @override
   @failingTest
-  void test_finalClass() {
-    super.test_finalClass();
-  }
-
-  @override
-  @failingTest
   void test_finalConstructor() {
     super.test_finalConstructor();
   }
 
   @override
   @failingTest
-  void test_finalEnum() {
-    super.test_finalEnum();
-  }
-
-  @override
-  @failingTest
   void test_finalMethod() {
     super.test_finalMethod();
   }
 
   @override
   @failingTest
-  void test_finalTypedef() {
-    super.test_finalTypedef();
-  }
-
-  @override
-  @failingTest
   void test_functionTypedParameter_const() {
     super.test_functionTypedParameter_const();
   }
 
   @override
   @failingTest
   void test_functionTypedParameter_final() {
     super.test_functionTypedParameter_final();
   }
 
@@ skipping 839 matching lines @@
   }
 
   @override
   @failingTest
   void test_staticSetterWithoutBody() {
     super.test_staticSetterWithoutBody();
   }
 
   @override
   @failingTest
-  void test_staticTopLevelDeclaration_class() {
-    super.test_staticTopLevelDeclaration_class();
-  }
-
-  @override
-  @failingTest
-  void test_staticTopLevelDeclaration_enum() {
-    super.test_staticTopLevelDeclaration_enum();
-  }
-
-  @override
-  @failingTest
-  void test_staticTopLevelDeclaration_function() {
-    super.test_staticTopLevelDeclaration_function();
-  }
-
-  @override
-  @failingTest
-  void test_staticTopLevelDeclaration_typedef() {
-    super.test_staticTopLevelDeclaration_typedef();
-  }
-
-  @override
-  @failingTest
-  void test_staticTopLevelDeclaration_variable() {
-    super.test_staticTopLevelDeclaration_variable();
-  }
-
-  @override
-  @failingTest
   void test_string_unterminated_interpolation_block() {
     super.test_string_unterminated_interpolation_block();
   }
 
   @override
   @failingTest
   void test_switchHasCaseAfterDefaultCase() {
     super.test_switchHasCaseAfterDefaultCase();
   }
 
@@ skipping 788 matching lines @@
     return result;
   }
 
   List<ErrorCode> _toFastaGeneratedAnalyzerErrorCodes(
           List<ErrorCode> expectedErrorCodes) =>
       expectedErrorCodes.map((code) {
         if (code == ParserErrorCode.ABSTRACT_CLASS_MEMBER ||
             code == ParserErrorCode.ABSTRACT_ENUM ||
             code == ParserErrorCode.ABSTRACT_TOP_LEVEL_FUNCTION ||
             code == ParserErrorCode.ABSTRACT_TOP_LEVEL_VARIABLE ||
-            code == ParserErrorCode.ABSTRACT_TYPEDEF)
+            code == ParserErrorCode.ABSTRACT_TYPEDEF ||
+            code == ParserErrorCode.CONST_ENUM ||
+            code == ParserErrorCode.CONST_TYPEDEF ||
+            code == ParserErrorCode.FINAL_CLASS ||
+            code == ParserErrorCode.FINAL_ENUM ||
+            code == ParserErrorCode.FINAL_TYPEDEF ||
+            code == ParserErrorCode.STATIC_TOP_LEVEL_DECLARATION)
           return ParserErrorCode.EXTRANEOUS_MODIFIER;
         return code;
       }).toList();
 }
 
 /**
  * Tests of the fasta parser based on [FormalParameterParserTestMixin].
  */
 @reflectiveTest
 class FormalParameterParserTest_Fasta extends FastaParserTestCase
@@ skipping 1784 matching lines @@
     allowNativeClause = false;
     test_parseClassDeclaration_native_missing_literal();
   }
 
   void test_parseClassDeclaration_native_not_allowed() {
     allowNativeClause = false;
     test_parseClassDeclaration_native();
   }
 
   @override
+  void test_parseCompilationUnit_builtIn_asFunctionName() {
+    //super.test_parseCompilationUnit_builtIn_asFunctionName();
+
+    // This is a subset of
+    // super.test_parseCompilationUnit_builtIn_asFunctionName
+    // that passes. The remainder are in the
+    // test_parseCompilationUnit_builtIn_asFunctionName2 method below
+    parseCompilationUnit('abstract(x) => 0;');
+    parseCompilationUnit('as(x) => 0;');
+    parseCompilationUnit('dynamic(x) => 0;');
+    parseCompilationUnit('external(x) => 0;');
+    parseCompilationUnit('factory(x) => 0;');
+    parseCompilationUnit('get(x) => 0;');
+    parseCompilationUnit('implements(x) => 0;');
+    parseCompilationUnit('operator(x) => 0;');
+    parseCompilationUnit('set(x) => 0;');
+    parseCompilationUnit('static(x) => 0;');
+    parseCompilationUnit('static(abstract) => 0;');
+    parseCompilationUnit('typedef(x) => 0;');
+  }
+
   @failingTest
-  void test_parseCompilationUnit_abstractAsPrefix_parameterized() {
-    // TODO(danrubel): built-in "abstract" cannot be used as a type
-    super.test_parseCompilationUnit_abstractAsPrefix_parameterized();
+  void test_parseCompilationUnit_builtIn_asFunctionName2() {
+    // TODO(paulberry,ahe): Fasta's parser is confused when one of the built-in
+    // identifiers `export`, `import`, `library`, `part`, or `typedef` appears
+    // as the name of a top level function with an implicit return type.
+    parseCompilationUnit('export(x) => 0;');
+    parseCompilationUnit('import(x) => 0;');
+    parseCompilationUnit('library(x) => 0;');
+    parseCompilationUnit('part(x) => 0;');
   }
 
   @override
-  @failingTest
-  void test_parseCompilationUnit_builtIn_asFunctionName() {
-    // TODO(paulberry,ahe): Fasta's parser is confused when one of the built-in
-    // identifiers `export`, `import`, `library`, `part`, or `typedef` appears
-    // as the name of a top level function with an implicit return type.
-    super.test_parseCompilationUnit_builtIn_asFunctionName();
-  }
-
-  @override
   @failingTest
   void test_parseCompilationUnit_exportAsPrefix() {
     // TODO(paulberry): As of commit 5de9108 this syntax is invalid.
     super.test_parseCompilationUnit_exportAsPrefix();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnit_exportAsPrefix_parameterized() {
     // TODO(paulberry): As of commit 5de9108 this syntax is invalid.
@@ skipping 31 matching lines @@
   @override
   @failingTest
   void test_parseDirectives_mixed() {
     // TODO(paulberry,ahe): This test verifies the analyzer parser's ability to
     // stop parsing as soon as the first non-directive is encountered; this is
     // useful for quickly traversing an import graph.  Consider adding a similar
     // ability to Fasta's parser.
     super.test_parseDirectives_mixed();
   }
 }