Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 3007383002: Replace voe_auto_test (Closed)

Created:
3 years, 3 months ago by the sun
Modified:
3 years, 3 months ago
Reviewers:
ossu, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove voe_auto_test and add new tests to cover the missing cases. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/3007383002 Cr-Commit-Position: refs/heads/master@{#19865} Committed: https://webrtc.googlesource.com/src/+/18f5427e4c21abb3fe74fbee158f3cba5c1b0127

Patch Set 1 #

Patch Set 2 : replace rtp/rtcp tests #

Patch Set 3 : replace remaining tests and remove voe_auto_test #

Patch Set 4 : remove voe_auto_test build target #

Patch Set 5 : rebase #

Total comments: 23

Patch Set 6 : reviewer comments #

Patch Set 7 : reviewer comment #

Total comments: 2

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Patch Set 10 : reviewer comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -1573 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
M audio/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A audio/audio_send_stream_tests.cc View 1 2 3 4 5 6 7 8 9 1 chunk +238 lines, -0 lines 0 comments Download
M test/constants.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M test/constants.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M voice_engine/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -67 lines 0 comments Download
D voice_engine/test/auto_test/automated_mode.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -23 lines 0 comments Download
D voice_engine/test/auto_test/automated_mode.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -28 lines 0 comments Download
D voice_engine/test/auto_test/fixtures/after_initialization_fixture.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -169 lines 0 comments Download
D voice_engine/test/auto_test/fixtures/after_initialization_fixture.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -36 lines 0 comments Download
D voice_engine/test/auto_test/fixtures/after_streaming_fixture.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -30 lines 0 comments Download
D voice_engine/test/auto_test/fixtures/after_streaming_fixture.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -21 lines 0 comments Download
D voice_engine/test/auto_test/fixtures/before_initialization_fixture.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -54 lines 0 comments Download
D voice_engine/test/auto_test/fixtures/before_initialization_fixture.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -38 lines 0 comments Download
D voice_engine/test/auto_test/fixtures/before_streaming_fixture.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -52 lines 0 comments Download
D voice_engine/test/auto_test/fixtures/before_streaming_fixture.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -78 lines 0 comments Download
D voice_engine/test/auto_test/standard/codec_before_streaming_test.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -88 lines 0 comments Download
D voice_engine/test/auto_test/standard/codec_test.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -216 lines 0 comments Download
D voice_engine/test/auto_test/standard/dtmf_test.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -66 lines 0 comments Download
D voice_engine/test/auto_test/standard/rtp_rtcp_before_streaming_test.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -50 lines 0 comments Download
D voice_engine/test/auto_test/standard/rtp_rtcp_extensions.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -120 lines 0 comments Download
D voice_engine/test/auto_test/standard/rtp_rtcp_test.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -120 lines 0 comments Download
D voice_engine/test/auto_test/voe_standard_test.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -52 lines 0 comments Download
D voice_engine/test/auto_test/voe_standard_test.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -120 lines 0 comments Download
D voice_engine/test/auto_test/voe_test_common.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -31 lines 0 comments Download
D voice_engine/test/auto_test/voe_test_defines.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
the sun
3 years, 3 months ago (2017-09-13 14:15:54 UTC) #3
the sun
On 2017/09/13 14:15:54, the sun wrote: Added kwiberg@ for webrtc/test/ and BUILD.gn.
3 years, 3 months ago (2017-09-13 14:16:58 UTC) #5
kwiberg-webrtc
On 2017/09/13 14:16:58, the sun wrote: > On 2017/09/13 14:15:54, the sun wrote: > > ...
3 years, 3 months ago (2017-09-13 14:25:35 UTC) #6
ossu
Nice work! Looks like we're getting rid of quite a lot of fixtures that were ...
3 years, 3 months ago (2017-09-14 11:51:58 UTC) #7
the sun
https://codereview.webrtc.org/3007383002/diff/80001/webrtc/audio/audio_send_stream_tests.cc File webrtc/audio/audio_send_stream_tests.cc (right): https://codereview.webrtc.org/3007383002/diff/80001/webrtc/audio/audio_send_stream_tests.cc#newcode41 webrtc/audio/audio_send_stream_tests.cc:41: CNameObserver() : AudioSendTest() {} On 2017/09/14 11:51:58, ossu wrote: ...
3 years, 3 months ago (2017-09-14 12:36:40 UTC) #8
ossu
https://codereview.webrtc.org/3007383002/diff/80001/webrtc/audio/audio_send_stream_tests.cc File webrtc/audio/audio_send_stream_tests.cc (right): https://codereview.webrtc.org/3007383002/diff/80001/webrtc/audio/audio_send_stream_tests.cc#newcode88 webrtc/audio/audio_send_stream_tests.cc:88: LOG(LS_WARNING) << "Got a packet with zero audioLevel - ...
3 years, 3 months ago (2017-09-14 12:51:32 UTC) #9
the sun
https://codereview.webrtc.org/3007383002/diff/80001/webrtc/audio/audio_send_stream_tests.cc File webrtc/audio/audio_send_stream_tests.cc (right): https://codereview.webrtc.org/3007383002/diff/80001/webrtc/audio/audio_send_stream_tests.cc#newcode88 webrtc/audio/audio_send_stream_tests.cc:88: LOG(LS_WARNING) << "Got a packet with zero audioLevel - ...
3 years, 3 months ago (2017-09-14 20:05:06 UTC) #14
ossu
https://codereview.webrtc.org/3007383002/diff/120001/webrtc/audio/audio_send_stream_tests.cc File webrtc/audio/audio_send_stream_tests.cc (right): https://codereview.webrtc.org/3007383002/diff/120001/webrtc/audio/audio_send_stream_tests.cc#newcode208 webrtc/audio/audio_send_stream_tests.cc:208: } else { So, now we only advance the ...
3 years, 3 months ago (2017-09-15 12:20:22 UTC) #19
the sun
https://codereview.webrtc.org/3007383002/diff/120001/webrtc/audio/audio_send_stream_tests.cc File webrtc/audio/audio_send_stream_tests.cc (right): https://codereview.webrtc.org/3007383002/diff/120001/webrtc/audio/audio_send_stream_tests.cc#newcode208 webrtc/audio/audio_send_stream_tests.cc:208: } else { On 2017/09/15 12:20:21, ossu wrote: > ...
3 years, 3 months ago (2017-09-15 13:08:26 UTC) #20
ossu
lgtm!
3 years, 3 months ago (2017-09-15 13:09:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007383002/170001
3 years, 3 months ago (2017-09-15 13:10:03 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, build has not started yet; ...
3 years, 3 months ago (2017-09-15 15:10:33 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007383002/170001
3 years, 3 months ago (2017-09-15 16:53:14 UTC) #28
commit-bot: I haz the power
3 years, 3 months ago (2017-09-15 16:56:17 UTC) #31
Message was sent while issue was closed.
Committed patchset #10 (id:170001) as
https://webrtc.googlesource.com/src/+/18f5427e4c21abb3fe74fbee158f3cba5c1b0127

Powered by Google App Engine
This is Rietveld 408576698