Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2187)

Unified Diff: voice_engine/test/auto_test/standard/codec_before_streaming_test.cc

Issue 3007383002: Replace voe_auto_test (Closed)
Patch Set: reviewer comment Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: voice_engine/test/auto_test/standard/codec_before_streaming_test.cc
diff --git a/voice_engine/test/auto_test/standard/codec_before_streaming_test.cc b/voice_engine/test/auto_test/standard/codec_before_streaming_test.cc
deleted file mode 100644
index 969aad1d536d46d1a42678d3d66a886c200624c2..0000000000000000000000000000000000000000
--- a/voice_engine/test/auto_test/standard/codec_before_streaming_test.cc
+++ /dev/null
@@ -1,88 +0,0 @@
-/*
- * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#include "voice_engine/channel_proxy.h"
-#include "voice_engine/test/auto_test/fixtures/after_initialization_fixture.h"
-#include "voice_engine/voice_engine_impl.h"
-
-class CodecBeforeStreamingTest : public AfterInitializationFixture {
- protected:
- void SetUp() {
- memset(&codec_instance_, 0, sizeof(codec_instance_));
- codec_instance_.channels = 1;
- codec_instance_.plfreq = 16000;
- codec_instance_.pacsize = 480;
-
- channel_ = voe_base_->CreateChannel();
- static_cast<webrtc::VoiceEngineImpl*>(voice_engine_)
- ->GetChannelProxy(channel_)
- ->RegisterLegacyReceiveCodecs();
- }
-
- void TearDown() {
- voe_base_->DeleteChannel(channel_);
- }
-
- webrtc::CodecInst codec_instance_;
- int channel_;
-};
-
-// TODO(phoglund): add test which verifies default pltypes for various codecs.
-
-TEST_F(CodecBeforeStreamingTest, GetRecPayloadTypeFailsForInvalidCodecName) {
- strcpy(codec_instance_.plname, "SomeInvalidCodecName");
-
- // Should fail since the codec name is invalid.
- EXPECT_NE(0, voe_codec_->GetRecPayloadType(channel_, codec_instance_));
-}
-
-TEST_F(CodecBeforeStreamingTest, GetRecPayloadTypeRecognizesISAC) {
- strcpy(codec_instance_.plname, "iSAC");
- EXPECT_EQ(0, voe_codec_->GetRecPayloadType(channel_, codec_instance_));
- strcpy(codec_instance_.plname, "ISAC");
- EXPECT_EQ(0, voe_codec_->GetRecPayloadType(channel_, codec_instance_));
-}
-
-TEST_F(CodecBeforeStreamingTest, SetRecPayloadTypeCanChangeISACPayloadType) {
- strcpy(codec_instance_.plname, "ISAC");
- codec_instance_.rate = 32000;
-
- codec_instance_.pltype = 123;
- EXPECT_EQ(0, voe_codec_->SetRecPayloadType(channel_, codec_instance_));
- EXPECT_EQ(0, voe_codec_->GetRecPayloadType(channel_, codec_instance_));
- EXPECT_EQ(123, codec_instance_.pltype);
-
- codec_instance_.pltype = 104;
- EXPECT_EQ(0, voe_codec_->SetRecPayloadType(channel_, codec_instance_));
- EXPECT_EQ(0, voe_codec_->GetRecPayloadType(channel_, codec_instance_));
-
- EXPECT_EQ(104, codec_instance_.pltype);
-}
-
-TEST_F(CodecBeforeStreamingTest, SetRecPayloadTypeCanChangeILBCPayloadType) {
- strcpy(codec_instance_.plname, "iLBC");
- codec_instance_.plfreq = 8000;
- codec_instance_.pacsize = 240;
- codec_instance_.rate = 13300;
-
- EXPECT_EQ(0, voe_codec_->GetRecPayloadType(channel_, codec_instance_));
- int original_pltype = codec_instance_.pltype;
- codec_instance_.pltype = 123;
- EXPECT_EQ(0, voe_codec_->SetRecPayloadType(channel_, codec_instance_));
- EXPECT_EQ(0, voe_codec_->GetRecPayloadType(channel_, codec_instance_));
-
- EXPECT_EQ(123, codec_instance_.pltype);
-
- codec_instance_.pltype = original_pltype;
- EXPECT_EQ(0, voe_codec_->SetRecPayloadType(channel_, codec_instance_));
- EXPECT_EQ(0, voe_codec_->GetRecPayloadType(channel_, codec_instance_));
-
- EXPECT_EQ(original_pltype, codec_instance_.pltype);
-}
« no previous file with comments | « voice_engine/test/auto_test/fixtures/before_streaming_fixture.cc ('k') | voice_engine/test/auto_test/standard/codec_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698