Create start menu shortcut when an ephemeral app is promoted

chrome/browser/apps/shortcut_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/apps/shortcut_manager.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/prefs/pref_service.h"
@@ skipping 91 matching lines @@
   DCHECK_EQ(chrome::NOTIFICATION_EXTENSIONS_READY, type);
   OnceOffCreateShortcuts();
 }
 
 void AppShortcutManager::OnExtensionWillBeInstalled(
     content::BrowserContext* browser_context,
     const Extension* extension,
     bool is_update,
     bool from_ephemeral,
     const std::string& old_name) {
+  if (!extension->is_app())

[tmdiep, 2014/05/28 05:13:34]

Added optimization here to avoid scanning for shortcuts when extensions are
updated. This change should not break crbug.com/353454.

+    return;
+
   // If the app is being updated, update any existing shortcuts but do not
   // create new ones. If it is being installed, automatically create a
   // shortcut in the applications menu (e.g., Start Menu).
-  if (is_update) {
+  if (is_update && !from_ephemeral) {
     web_app::UpdateAllShortcuts(
         base::UTF8ToUTF16(old_name), profile_, extension);
   } else if (ShouldCreateShortcutFor(profile_, extension)) {
     CreateShortcutsInApplicationsMenu(profile_, extension);
   }
 }
 
 void AppShortcutManager::OnExtensionUninstalled(
     content::BrowserContext* browser_context,
     const Extension* extension) {
@@ skipping 25 matching lines @@
     return;
 
   // Create an applications menu shortcut for each app in this profile.
   const extensions::ExtensionSet* apps = extension_service->extensions();
   for (extensions::ExtensionSet::const_iterator it = apps->begin();
        it != apps->end(); ++it) {
     if (ShouldCreateShortcutFor(profile_, it->get()))
       CreateShortcutsInApplicationsMenu(profile_, it->get());
   }
 }