Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: runtime/observatory/tests/service/dev_fs_spawn_test.dart

Issue 3004563003: Refactor Isolate name format, storage and log (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/dev_fs_spawn_test.dart
diff --git a/runtime/observatory/tests/service/dev_fs_spawn_test.dart b/runtime/observatory/tests/service/dev_fs_spawn_test.dart
index 10b23b01d03b1c2b81f1ce6ec79c562f2690dd68..662529747c219b6e22214ffc3541f471512d8439 100644
--- a/runtime/observatory/tests/service/dev_fs_spawn_test.dart
+++ b/runtime/observatory/tests/service/dev_fs_spawn_test.dart
@@ -119,7 +119,7 @@ main(args, msg) {
if (event.kind == ServiceEvent.kIsolateSpawn) {
expect(event.spawnToken, equals('mySpawnToken0'));
expect(event.isolate, isNotNull);
- expect(event.isolate.name, equals('devfs_file0.dart\$main'));
+ expect(event.isolate.name, equals('devfs_file0.dart:main()'));
completer.complete(event.isolate);
sub.cancel();
}
@@ -147,7 +147,7 @@ main(args, msg) {
if (event.kind == ServiceEvent.kIsolateSpawn) {
expect(event.spawnToken, equals('mySpawnToken1'));
expect(event.isolate, isNotNull);
- expect(event.isolate.name, equals('devfs_file1.dart\$main'));
+ expect(event.isolate.name, equals('devfs_file1.dart:main()'));
completer.complete(event.isolate);
sub.cancel();
}
@@ -176,7 +176,7 @@ main(args, msg) {
if (event.kind == ServiceEvent.kIsolateSpawn) {
expect(event.spawnToken, equals('mySpawnToken2'));
expect(event.isolate, isNotNull);
- expect(event.isolate.name, equals('devfs_file2.dart\$main'));
+ expect(event.isolate.name, equals('devfs_file2.dart\:main()'));
rmacnak 2017/08/24 19:00:19 The colon doesn't need to be escaped.
cbernaschina 2017/08/24 20:19:33 Done.
completer.complete(event.isolate);
sub.cancel();
}

Powered by Google App Engine
This is Rietveld 408576698