Refactor Isolate name format, storage and log

runtime/observatory/tests/service/dev_fs_spawn_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // VMOptions=--error_on_bad_type --error_on_bad_override
 
 import 'dart:async';
 import 'dart:convert';
 import 'package:observatory/models.dart' as M;
 import 'package:observatory/service_io.dart';
 import 'package:unittest/unittest.dart';
@@ skipping 101 matching lines @@
     }
 
     // Spawn the script with no arguments or message and make sure
     // that we are notified.
     Completer completer = new Completer();
     var sub;
     sub = await vm.listenEventStream(VM.kIsolateStream, (ServiceEvent event) {
       if (event.kind == ServiceEvent.kIsolateSpawn) {
         expect(event.spawnToken, equals('mySpawnToken0'));
         expect(event.isolate, isNotNull);
-        expect(event.isolate.name, equals('devfs_file0.dart\$main'));
+        expect(event.isolate.name, equals('devfs_file0.dart:main()'));
         completer.complete(event.isolate);
         sub.cancel();
       }
     });
     result = await vm.invokeRpcNoUpgrade('_spawnUri', {
       'token': 'mySpawnToken0',
       'uri': '${fsUri}${filePaths[0]}',
     });
     expect(result['type'], equals('Success'));
     var spawnedIsolate = await completer.future;
 
     // Wait for the spawned isolate to hit a breakpoint.
     await spawnedIsolate.load();
     await hasStoppedAtBreakpoint(spawnedIsolate);
 
     // Make sure that we are running code from the spawned isolate.
     result = await spawnedIsolate.rootLibrary.evaluate('proofOfLife()');
     expect(result.type, equals('Instance'));
     expect(result.kind, equals(M.InstanceKind.string));
     expect(result.valueAsString, equals('I live!'));
 
     // Spawn the script with arguments.
     completer = new Completer();
     sub = await vm.listenEventStream(VM.kIsolateStream, (ServiceEvent event) {
       if (event.kind == ServiceEvent.kIsolateSpawn) {
         expect(event.spawnToken, equals('mySpawnToken1'));
         expect(event.isolate, isNotNull);
-        expect(event.isolate.name, equals('devfs_file1.dart\$main'));
+        expect(event.isolate.name, equals('devfs_file1.dart:main()'));
         completer.complete(event.isolate);
         sub.cancel();
       }
     });
     result = await vm.invokeRpcNoUpgrade('_spawnUri', {
       'token': 'mySpawnToken1',
       'uri': '${fsUri}${filePaths[1]}',
       'args': ['one', 'two', 'three']
     });
     expect(result['type'], equals('Success'));
     spawnedIsolate = await completer.future;
 
     // Wait for the spawned isolate to hit a breakpoint.
     await spawnedIsolate.load();
     await hasStoppedAtBreakpoint(spawnedIsolate);
 
     // Make sure that we are running code from the spawned isolate.
     result = await spawnedIsolate.rootLibrary.evaluate('proofOfLife()');
     expect(result.type, equals('Instance'));
     expect(result.kind, equals(M.InstanceKind.string));
     expect(result.valueAsString, equals('I live, [one, two, three]!'));
 
     // Spawn the script with arguments and message
     completer = new Completer();
     sub = await vm.listenEventStream(VM.kIsolateStream, (ServiceEvent event) {
       if (event.kind == ServiceEvent.kIsolateSpawn) {
         expect(event.spawnToken, equals('mySpawnToken2'));
         expect(event.isolate, isNotNull);
-        expect(event.isolate.name, equals('devfs_file2.dart\$main'));
+        expect(event.isolate.name, equals('devfs_file2.dart\:main()'));

[rmacnak, 2017/08/24 19:00:19]

The colon doesn't need to be escaped.

[cbernaschina, 2017/08/24 20:19:33]

Done.

         completer.complete(event.isolate);
         sub.cancel();
       }
     });
     result = await vm.invokeRpcNoUpgrade('_spawnUri', {
       'token': 'mySpawnToken2',
       'uri': '${fsUri}${filePaths[2]}',
       'args': ['A', 'B', 'C'],
       'message': 'test'
     });
@@ skipping 12 matching lines @@
 
     // Delete the fs.
     result = await vm.invokeRpcNoUpgrade('_deleteDevFS', {
       'fsName': fsName,
     });
     expect(result['type'], equals('Success'));
   },
 ];
 
 main(args) async => runVMTests(args, tests);