Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/observatory/tests/service/set_name_rpc_test.dart

Issue 3004563003: Refactor Isolate name format, storage and log (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/observatory/tests/service/dev_fs_spawn_test.dart ('K') | « runtime/observatory/tests/service/dev_fs_spawn_test.dart ('k') | runtime/vm/compiler_stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/set_name_rpc_test.dart
diff --git a/runtime/observatory/tests/service/set_name_rpc_test.dart b/runtime/observatory/tests/service/set_name_rpc_test.dart
index b43af7df50227edf8b48753c853a036a4970808b..8320b914bac1c7bd76de7813d80749e28ee83dff 100644
--- a/runtime/observatory/tests/service/set_name_rpc_test.dart
+++ b/runtime/observatory/tests/service/set_name_rpc_test.dart
@@ -10,7 +10,7 @@ import 'dart:async';
var tests = [
(Isolate isolate) async {
- expect(isolate.name, equals('set_name_rpc_test.dart\$main'));
+ expect(isolate.name, equals('set_name_rpc_test.dart\:main()'));
rmacnak 2017/08/24 19:00:19 The colon doesn't need to be escaped.
cbernaschina 2017/08/24 20:19:33 Done.
Completer completer = new Completer();
var stream = await isolate.vm.getEventStream(VM.kIsolateStream);
« runtime/observatory/tests/service/dev_fs_spawn_test.dart ('K') | « runtime/observatory/tests/service/dev_fs_spawn_test.dart ('k') | runtime/vm/compiler_stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698