Refactor Isolate name format, storage and log

Refactor Isolate name format, storage and log

At the moment isolated has a name field which is on the main_port the
only exception is the vm-service isolate.
The name is used just for logging.

The service protocol though uses an extra field called debugger_name,
that at this moment is redundant and is optimized away during
compilation.

BUG=
R=rmacnak@google.com, zra@google.com

This CL:
- Removes the debugger_name in favor of a modifiable name
- Adds to all the log where the name was logged the main_port (that is
  the only real identifier)
- Changes the default format of the isolate name from:
    <script_uri>$<main>
  to:
    <script_uri>:<main>()
Committed: https://github.com/dart-lang/sdk/commit/cf4cc1973a35b4b17c13f6e919d4ce470bd45fd9

[cbernaschina, 2017-08-24 18:20:39]

cbernaschina@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com, zanderso@gmail.com

[rmacnak, 2017-08-24 19:00:19]

lgtm

https://codereview.chromium.org/3004563003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/dev_fs_spawn_test.dart (right):

https://codereview.chromium.org/3004563003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/dev_fs_spawn_test.dart:179:
expect(event.isolate.name, equals('devfs_file2.dart\:main()'));
The colon doesn't need to be escaped.

https://codereview.chromium.org/3004563003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/set_name_rpc_test.dart (right):

https://codereview.chromium.org/3004563003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/set_name_rpc_test.dart:13:
expect(isolate.name, equals('set_name_rpc_test.dart\:main()'));
The colon doesn't need to be escaped.

[cbernaschina, 2017-08-24 20:19:33]

https://codereview.chromium.org/3004563003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/dev_fs_spawn_test.dart (right):

https://codereview.chromium.org/3004563003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/dev_fs_spawn_test.dart:179:
expect(event.isolate.name, equals('devfs_file2.dart\:main()'));
On 2017/08/24 19:00:19, rmacnak wrote:
> The colon doesn't need to be escaped.

Done.

https://codereview.chromium.org/3004563003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/set_name_rpc_test.dart (right):

https://codereview.chromium.org/3004563003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/set_name_rpc_test.dart:13:
expect(isolate.name, equals('set_name_rpc_test.dart\:main()'));
On 2017/08/24 19:00:19, rmacnak wrote:
> The colon doesn't need to be escaped.

Done.

[cbernaschina, 2017-08-24 20:21:39]

Description was changed from

==========
Refactor Isolate name format, storage and log

At the moment isolated has a name field which is on the main_port the
only exception is the vm-service isolate.
The name is used just for logging.

The service protocol though uses an extra field called debugger_name,
that at this moment is redundant and is optimized away during
compilation.

BUG=

This CL:
- Removes the debugger_name in favor of a modifiable name
- Adds to all the log where the name was logged the main_port (that is
  the only real identifier)
- Changes the default format of the isolate name from:
    <script_uri>$<main>
  to:
    <script_uri>:<main>()
==========

to

==========
Refactor Isolate name format, storage and log

At the moment isolated has a name field which is on the main_port the
only exception is the vm-service isolate.
The name is used just for logging.

The service protocol though uses an extra field called debugger_name,
that at this moment is redundant and is optimized away during
compilation.

BUG=

This CL:
- Removes the debugger_name in favor of a modifiable name
- Adds to all the log where the name was logged the main_port (that is
  the only real identifier)
- Changes the default format of the isolate name from:
    <script_uri>$<main>
  to:
    <script_uri>:<main>()
==========

[cbernaschina, 2017-08-24 20:21:40]

cbernaschina@google.com changed reviewers:
+ zra@google.com
- zanderso@gmail.com

[zra, 2017-08-24 20:57:08]

It looks like this change will break FlutterView filtering in the Flutter tool.

[cbernaschina, 2017-08-24 21:35:19]

On 2017/08/24 20:57:08, zra wrote:
> It looks like this change will break FlutterView filtering in the Flutter
tool.

Right now the Flutter Engine is using Dart_DebugName:
https://github.com/flutter/engine/blob/29f289acbbc0ffa86e5233f0acbeca4aa716fb...
supposing to always get '$script_uri\$main-$main_port'.
The definition of Dart_DebugName though is not guaranteeing that format, or even
guaranteeing that the name will be constant.
https://github.com/dart-lang/sdk/blob/14b57825445389964310381e9098d62b24ff370...
`should only be used to make debugging messages more comprehensible`
As a confirmation here is the test.
https://github.com/dart-lang/sdk/blob/14b57825445389964310381e9098d62b24ff370...

To keep the uniqueness of the return value of Dart_DebugName we can add the
main_port number in the value returned in:
https://github.com/dart-lang/sdk/blob/8039138f39e1379f2fa60d5ae9f0b997940c661...

We can force the format in the engine by injecting the script_uri in the
UIDartState in
https://github.com/flutter/engine/blob/ba9a525bdcdd859cb12dd9e6e2d9678c2ae9c9...
https://github.com/flutter/engine/blob/a246501917b8b77e856db253817ce7c2cc25b9...
https://github.com/flutter/engine/blob/a246501917b8b77e856db253817ce7c2cc25b9...
and create the desired format in
https://github.com/flutter/engine/blob/29f289acbbc0ffa86e5233f0acbeca4aa716fb...

[cbernaschina, 2017-08-25 18:12:23]

On 2017/08/24 21:45:35, cbernaschina wrote:

https://github.com/flutter/engine/pull/4007#pullrequestreview-58720781

[zra, 2017-08-25 19:20:44]

lgtm

[cbernaschina, 2017-08-26 01:07:11]

Description was changed from

==========
Refactor Isolate name format, storage and log

At the moment isolated has a name field which is on the main_port the
only exception is the vm-service isolate.
The name is used just for logging.

The service protocol though uses an extra field called debugger_name,
that at this moment is redundant and is optimized away during
compilation.

BUG=

This CL:
- Removes the debugger_name in favor of a modifiable name
- Adds to all the log where the name was logged the main_port (that is
  the only real identifier)
- Changes the default format of the isolate name from:
    <script_uri>$<main>
  to:
    <script_uri>:<main>()
==========

to

==========
Refactor Isolate name format, storage and log

At the moment isolated has a name field which is on the main_port the
only exception is the vm-service isolate.
The name is used just for logging.

The service protocol though uses an extra field called debugger_name,
that at this moment is redundant and is optimized away during
compilation.

BUG=
R=rmacnak@google.com, zra@google.com

This CL:
- Removes the debugger_name in favor of a modifiable name
- Adds to all the log where the name was logged the main_port (that is
  the only real identifier)
- Changes the default format of the isolate name from:
    <script_uri>$<main>
  to:
    <script_uri>:<main>()
Committed:
https://github.com/dart-lang/sdk/commit/cf4cc1973a35b4b17c13f6e919d4ce470bd45fd9
==========

[cbernaschina, 2017-08-26 01:07:12]

Committed patchset #3 (id:40001) manually as
cf4cc1973a35b4b17c13f6e919d4ce470bd45fd9 (presubmit successful).