Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: runtime/observatory/tests/service/set_name_rpc_test.dart

Issue 3004563003: Refactor Isolate name format, storage and log (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override --vm-name=Walter 4 // VMOptions=--error_on_bad_type --error_on_bad_override --vm-name=Walter
5 5
6 import 'package:observatory/service_io.dart'; 6 import 'package:observatory/service_io.dart';
7 import 'package:unittest/unittest.dart'; 7 import 'package:unittest/unittest.dart';
8 import 'test_helper.dart'; 8 import 'test_helper.dart';
9 import 'dart:async'; 9 import 'dart:async';
10 10
11 var tests = [ 11 var tests = [
12 (Isolate isolate) async { 12 (Isolate isolate) async {
13 expect(isolate.name, equals('set_name_rpc_test.dart\$main')); 13 expect(isolate.name, equals('set_name_rpc_test.dart\:main()'));
rmacnak 2017/08/24 19:00:19 The colon doesn't need to be escaped.
cbernaschina 2017/08/24 20:19:33 Done.
14 14
15 Completer completer = new Completer(); 15 Completer completer = new Completer();
16 var stream = await isolate.vm.getEventStream(VM.kIsolateStream); 16 var stream = await isolate.vm.getEventStream(VM.kIsolateStream);
17 var subscription; 17 var subscription;
18 subscription = stream.listen((ServiceEvent event) { 18 subscription = stream.listen((ServiceEvent event) {
19 if (event.kind == ServiceEvent.kIsolateUpdate) { 19 if (event.kind == ServiceEvent.kIsolateUpdate) {
20 expect(event.owner.type, equals('Isolate')); 20 expect(event.owner.type, equals('Isolate'));
21 expect(event.owner.name, equals('Barbara')); 21 expect(event.owner.name, equals('Barbara'));
22 subscription.cancel(); 22 subscription.cancel();
23 completer.complete(); 23 completer.complete();
24 } 24 }
25 }); 25 });
26 26
27 var result = await isolate.setName('Barbara'); 27 var result = await isolate.setName('Barbara');
28 expect(result.type, equals('Success')); 28 expect(result.type, equals('Success'));
29 29
30 await completer.future; 30 await completer.future;
31 expect(isolate.name, equals('Barbara')); 31 expect(isolate.name, equals('Barbara'));
32 } 32 }
33 ]; 33 ];
34 34
35 main(args) async => runIsolateTests(args, tests); 35 main(args) async => runIsolateTests(args, tests);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698