Add more tests for closures and change closure indexing to be by FunctionExpression or FunctionDecl…

Add more tests for closures and change closure indexing to be by FunctionExpression or FunctionDeclaration rather than FunctionNode.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/63754bba710bc281c98cb3e4db90c944c7159fd7

[Emily Fortuna, 2017-08-26 02:03:44]

efortuna@google.com changed reviewers:
+ sra@google.com

[Emily Fortuna, 2017-08-26 02:03:55]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-08-27 19:58:58]

Patchset #2 (id:30001) has been deleted

[Siggi Cherem (dart-lang), 2017-08-28 17:33:45]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-28 17:33:46]

lgtm

https://codereview.chromium.org/3003963002/diff/50001/tests/compiler/dart2js/...
File tests/compiler/dart2js/closure/closure_test.dart (right):

https://codereview.chromium.org/3003963002/diff/50001/tests/compiler/dart2js/...
tests/compiler/dart2js/closure/closure_test.dart:257: // TODO(johnniwinther):
This can't happen!
nit: rewrite to explain what this means? not sure what is it that it can't
happen.

https://codereview.chromium.org/3003963002/diff/50001/tests/compiler/dart2js/...
tests/compiler/dart2js/closure/closure_test.dart:258: features.add('box');
maybe use a different string to denote this is an error situation? 'error-box'?

https://codereview.chromium.org/3003963002/diff/50001/tests/compiler/dart2js/...
tests/compiler/dart2js/closure/closure_test.dart:299: //print('-------------
$object from $capturedScope');
delete

https://codereview.chromium.org/3003963002/diff/50001/tests/compiler/dart2js/...
tests/compiler/dart2js/closure/closure_test.dart:302: addLocals('boxed',
capturedScope.forEachBoxedVariable);
an idea: since this and requiresContextBox are correlated, it might be nice to
combine them. I think this can make the comments on the test easier to read.

Instead of:
  box=box0,boxed=[x,y]

We would have something like:

  box=(box0 which holds [x,y])

or:

  box={name: "box0", variables:[x,y]}


thoughts?

https://codereview.chromium.org/3003963002/diff/50001/tests/compiler/dart2js/...
File tests/compiler/dart2js/closure/data/mixed.dart (right):

https://codereview.chromium.org/3003963002/diff/50001/tests/compiler/dart2js/...
tests/compiler/dart2js/closure/data/mixed.dart:8:
/*mutateInClosure:box=box0,boxed=[local]*/
nit: consider using a different variable name  - I believe you got rid of the
"local" feature, but when I read "local" in some of the comments, I was not sure
if it's referring to a variable or a feature. This might also be less of an
issue if we combine the box0/boxed comment here.

[Emily Fortuna, 2017-08-28 21:25:03]

Description was changed from

==========
Add more tests for closures and change closure indexing to be by
FunctionExpression or FunctionDeclaration rather than FunctionNode.

BUG=
==========

to

==========
Add more tests for closures and change closure indexing to be by
FunctionExpression or FunctionDeclaration rather than FunctionNode.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/63754bba710bc281c98cb3e4db90c944c7159fd7
==========

[Emily Fortuna, 2017-08-28 21:25:04]

Committed patchset #2 (id:50001) manually as
63754bba710bc281c98cb3e4db90c944c7159fd7 (presubmit successful).