Add more tests for closures and change closure indexing to be by FunctionExpression or FunctionDecl…

tests/language_2/language_2_dart2js.status

 # Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # Sections in this file should contain "$compiler == dart2js".
 
 # dart2js does not implement the Dart 2.0 static type errors yet.
 [ $compiler == dart2js ]
 abstract_beats_arguments_test: MissingCompileTimeError
 abstract_exact_selector_test/01: MissingCompileTimeError
@@ skipping 409 matching lines @@
 cascade_in_expression_function_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(Maps.mapToString#first) is stored in a closure field.
 cast_test/none: RuntimeError
 cha_deopt1_test: CompileTimeError
 cha_deopt2_test: CompileTimeError
 cha_deopt3_test: CompileTimeError
 class_cycle_test/02: MissingCompileTimeError
 class_cycle_test/03: MissingCompileTimeError
 class_syntax2_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(Maps.mapToString#first) is stored in a closure field.
 class_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(Sub.closureRef#)) for j:closure_call(Sub_closureRef_closure.call).
 classes_static_method_clash_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(Primitives.applyFunctionWithNamedArguments#bad) is stored in a closure field.
-closure4_test: Crash # Assertion failure: Cannot find value local(main#fun) in () for j:method(main).
-closure5_test: Crash # Assertion failure: Cannot find value local(main#fun) in () for j:method(main).
 closure6_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(A.foo#)) for j:closure_call(A_foo_closure.call).
 closure_cycles_test: Crash # 'file:*/pkg/compiler/lib/src/js_model/closure.dart': Failed assertion: line 197 pos 9: 'closure != null': Corresponding closure class not found for j:getter(Iterable.iterator). Closures found for (j:closure_call(Closure_fromTearOff_closure.call), j:closure_call(Maps_mapToString_closure.call), j:closure_call(doIt_closure.call), ..., j:closure_call(Duration_toString_closure.call), j:closure_call(Y_Y_closure.call))
 closure_in_constructor_test: Crash # type 'JClosureClass' is not a subtype of type 'ClosureClassElement' of 'closureClass' where
 closure_in_field_initializer_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(Maps.mapToString#first) is stored in a closure field.
 closure_in_initializer2_test: Crash # 'file:*/pkg/compiler/lib/src/js_model/closure.dart': Failed assertion: line 207 pos 9: 'closure != null': Corresponding closure class not found for () → dynamic => a = a.+(1). Closures found for (() → dynamic {
 closure_in_initializer_test: Crash # NoSuchMethodError: The getter 'parent' was called on null.
 closure_parameter_types_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(main#invokeCount) is stored in a closure field.
 closure_self_reference_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(main#inner) is stored in a closure field.
 closure_shared_state_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(setupNestedLoop#j) is stored in a closure field.
 closure_type_variable_test: Crash # NoSuchMethodError: The getter 'typeArguments' was called on null.
@@ skipping 154 matching lines @@
 canonical_const2_test: RuntimeError
 canonical_const_test: Crash # NoSuchMethodError: Class 'InterfaceType' has no instance getter 'kind'.
 cast_test/none: RuntimeError
 cha_deopt1_test: CompileTimeError
 cha_deopt2_test: CompileTimeError
 cha_deopt3_test: CompileTimeError
 class_cycle_test/02: MissingCompileTimeError
 class_cycle_test/03: MissingCompileTimeError
 class_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(Sub.closureRef#)) for j:closure_call(Sub_closureRef_closure.call).
 classes_static_method_clash_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(JsLinkedHashMap.addAll#key), local(JsLinkedHashMap.addAll#value), local(JsLinkedHashMap.addAll#)) for j:closure_call(JsLinkedHashMap_addAll_closure.call).
-closure4_test: Crash # Assertion failure: Cannot find value local(main#fun) in () for j:method(main).
-closure5_test: Crash # Assertion failure: Cannot find value local(main#fun) in () for j:method(main).
 closure6_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(A.foo#)) for j:closure_call(A_foo_closure.call).
 closure_cycles_test: Crash # NoSuchMethodError: The getter 'thisLocal' was called on null.
 closure_in_constructor_test: Crash # NoSuchMethodError: Class 'JClosureClass' has no instance getter 'methodElement'.
-closure_in_initializer2_test: Crash # NoSuchMethodError: The getter 'closureClassEntity' was called on null.
+closure_in_initializer2_test: RuntimeError
 closure_in_initializer_test: Crash # NoSuchMethodError: The getter 'parent' was called on null.
 closure_parameter_types_test: RuntimeError
-closure_self_reference_test: Crash # Stack Overflow
+closure_self_reference_test: RuntimeError
 closure_shared_state_test: RuntimeError
 closure_type_variable_test: Crash # NoSuchMethodError: The getter 'typeArguments' was called on null.
 closure_type_variables_test: Crash # NoSuchMethodError: Class 'JClosureClass' has no instance getter 'methodElement'.
 closure_with_super_field_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(B.returnSuperInClosure#)) for j:closure_call(B_returnSuperInClosure_closure.call).
 closure_with_super_send_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(Sub.test#e), local(Sub.test#)) for j:closure_call(Sub_test_closure.call).
 closures_initializer2_test: Crash # NoSuchMethodError: The getter 'closureClassEntity' was called on null.
 closures_initializer_test: Crash # NoSuchMethodError: The getter 'closureClassEntity' was called on null.
 closures_with_complex_params_test: Crash # NoSuchMethodError: Class 'JClosureClass' has no instance getter 'supertype'.
-regress_30339_test: Crash # NoSuchMethodError: The getter 'thisLocal' was called on null.
-typevariable_substitution2_test/02: RuntimeError
+compile_time_constant_a_test: Crash
+compile_time_constant_b_test: Crash
+compile_time_constant_c_test/02: Crash
 generic_instanceof_test: Crash
 generic_local_functions_test: Crash
 generic_methods_closure_test: Crash
 generic_methods_generic_class_tearoff_test: Crash
 generic_methods_generic_function_parameter_test: Crash
 generic_methods_named_parameters_test: Crash
 generic_methods_optional_parameters_test: Crash
 generic_methods_shadowing_test: Crash
 generic_methods_tearoff_specialization_test: Crash
 generic_methods_test: Crash
 generic_methods_type_expression_test: Crash
 generic_native_test: Crash
 generic_sync_star_test: Crash
 generic_syntax_test: Crash
 generic_test: Crash
 generic_test: RuntimeError
 generic_typedef_test: Crash
 many_generic_instanceof_test: Crash
-compile_time_constant_a_test: Crash
-compile_time_constant_b_test: Crash
-compile_time_constant_c_test/02: Crash
+regress_30339_test: Crash # NoSuchMethodError: The getter 'thisLocal' was called on null.
+typevariable_substitution2_test/02: RuntimeError
 
 [ $compiler == dart2js && ! $dart2js_with_kernel && $runtime != none ]
 async_star_cancel_while_paused_test: RuntimeError # Issue 22853
 
 [ $compiler == dart2js && $runtime == jsshell && ! $dart2js_with_kernel ]
 async_star_await_pauses_test: RuntimeError # Need triage
 async_star_no_cancel2_test: RuntimeError # Need triage
 async_star_no_cancel_test: RuntimeError # Need triage
 
 [ $compiler == dart2js && $checked && ! $dart2js_with_kernel ]
@@ skipping 49 matching lines @@
 function_type/function_type55_test: Crash # Issue 27394
 function_type/function_type62_test: Crash # Issue 27394
 function_type/function_type63_test: Crash # Issue 27394
 function_type/function_type6_test: Crash # Issue 27394
 function_type/function_type7_test: Crash # Issue 27394
 function_type/function_type98_test: Crash # Issue 27394
 function_type/function_type99_test: Crash # Issue 27394
 
 [ $compiler == dart2js && $runtime == safarimobilesim ]
 call_through_getter_test: Fail, OK