Add more tests for closures and change closure indexing to be by FunctionExpression or FunctionDecl…

tests/compiler/dart2js_extra/dart2js_extra.status

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 [ $compiler == dart2js ]
 class_test: Fail
 statements_test: Fail
 typed_locals_test: Fail
 no_such_method_test: Fail # Wrong Invocation.memberName.
 constant_javascript_semantics4_test: Fail, OK
@@ skipping 215 matching lines @@
 deferred_split_test: CompileTimeError
 dummy_compiler_test: CompileTimeError
 first_class_types_hashcode_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(Maps.mapToString#first) is stored in a closure field.
 for_in_test: Crash
 hash_code_test: Crash
 if_null2_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(Maps.mapToString#first) is stored in a closure field.
 if_null3_test: Crash # 'file:*/pkg/compiler/lib/src/ssa/locals_handler.dart': Failed assertion: line 425 pos 12: '!isStoredInClosureField(local)': Local local(Maps.mapToString#first) is stored in a closure field.
 if_null_test: Crash
 inference_nsm_mirrors_test: Crash
 inference_super_set_call_test: RuntimeError
-inline_position_crash_test: Crash
 interceptor_named_arguments_test: Crash
 invalid_annotation2_test/none: Crash
 is_check_instanceof_test: Crash
 js_dispatch_property_test: RuntimeError
 label_test/06: Crash
 lookup_map/dead_entry_single_nested_pairs_test: Crash
 lookup_map/dead_entry_test: Crash
 lookup_map/dead_entry_through_mirrors_test: Crash
 lookup_map/discovered_code_test: Crash
 lookup_map/entries_aside_test: Crash
@@ skipping 110 matching lines @@
 deferred_fail_and_retry_test: CompileTimeError
 deferred_fail_and_retry_worker_test: CompileTimeError
 deferred_inheritance_test: CompileTimeError
 deferred_split_test: CompileTimeError
 dummy_compiler_test: CompileTimeError
 for_in_test: Crash # NoSuchMethodError: The getter 'enclosingClass' was called on null.
 hash_code_test: Crash # UnimplementedError: Unexpected constant expression new #lib1::Hasher::•().hash (KernelPropertyGet)
 if_null_test: Crash # NoSuchMethodError: The getter 'memberIndex' was called on null.
 inference_nsm_mirrors_test: Crash # NoSuchMethodError: Class 'KMethod' has no instance getter 'memberContext'.
 inference_super_set_call_test: RuntimeError
-inline_position_crash_test: Crash # NoSuchMethodError: The getter 'classIndex' was called on null.
 interceptor_named_arguments_test: Crash # NoSuchMethodError: The getter 'memberIndex' was called on null.
 invalid_annotation2_test/none: Crash # NoSuchMethodError: Class 'DynamicType' has no instance getter 'element'.
 is_check_instanceof_test: Crash # NoSuchMethodError: The getter 'enclosingClass' was called on null.
 js_dispatch_property_test: RuntimeError
 label_test/06: Crash # RangeError (index): Invalid value: Valid value range is empty: 0
 lookup_map/dead_entry_single_nested_pairs_test: Crash # NoSuchMethodError: Class 'KField' has no instance getter 'constant'.
 lookup_map/dead_entry_test: Crash # NoSuchMethodError: Class 'KField' has no instance getter 'constant'.
 lookup_map/dead_entry_through_mirrors_test: Crash # NoSuchMethodError: Class 'KField' has no instance getter 'constant'.
 lookup_map/discovered_code_test: Crash # NoSuchMethodError: Class 'KField' has no instance getter 'constant'.
 lookup_map/entries_aside_test: Crash # NoSuchMethodError: Class 'KField' has no instance getter 'constant'.
@@ skipping 49 matching lines @@
 timer_test: Crash # NoSuchMethodError: The getter 'memberIndex' was called on null.
 to_string_test: Crash
 truncation_errors_test: Crash # Assertion failure: Cannot find value local(main_closure.call#Infinity) in (local(main#)) for j:closure_call(main_closure.call).
 type_argument_factory_crash_test: Crash # Assertion failure: Cannot find value local(Maps_mapToString_closure.call#first) in (local(Maps_mapToString_closure.call#k), local(Maps_mapToString_closure.call#v), local(Maps.mapToString#)) for j:closure_call(Maps_mapToString_closure.call).
 type_argument_factory_nocrash_test: Crash # Assertion failure: Cannot find value local(Maps_mapToString_closure.call#first) in (local(Maps_mapToString_closure.call#k), local(Maps_mapToString_closure.call#v), local(Maps.mapToString#)) for j:closure_call(Maps_mapToString_closure.call).
 type_constant_switch_test/01: MissingCompileTimeError
 type_error_message_test: Crash # NoSuchMethodError: The getter 'enclosingClass' was called on null.
 unconditional_dartio_import_test: CompileTimeError
 useful_error_message_1_test: Crash # NoSuchMethodError: The getter 'enclosingClass' was called on null.