Hide internal classes from Memory Profile

Hide internal classes from Memory Profile

The Service Protocol exposes a new private RPC _getDefaultClassesAliases
which returns a Map from internal classes to a String.

This Map is used to group internal classes and to avoid navigation to
patch files.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/89e72c7bb5aa7997cada71f806fed557b0fc08a6

[cbernaschina, 2017-08-25 19:26:34]

cbernaschina@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[cbernaschina, 2017-08-28 18:01:44]

Description was changed from

==========
Hide internal classes from Memory Profile

The Service Protocol exposes a new private RPC _getDefaultClassesAliases
which returns a Map from internal classes to a String.

This Map is used to group internal classes and to avoid navigation to
patch files.
==========

to

==========
Hide internal classes from Memory Profile

The Service Protocol exposes a new private RPC _getDefaultClassesAliases
which returns a Map from internal classes to a String.

This Map is used to group internal classes and to avoid navigation to
patch files.
==========

[cbernaschina, 2017-08-28 18:01:44]

cbernaschina@google.com changed reviewers:
+ zra@google.com

[rmacnak, 2017-08-28 22:51:08]

https://codereview.chromium.org/3003903002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/3003903002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4088: for (int32_t id = kClassCid; id <= kMixinAppTypeCid;
++id) {
intptr_t cid = kClassCid; cid < kInstanceCid; ++cid

kInstanceCid itself is a user type. E.g., new Object()

https://codereview.chromium.org/3003903002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4091: }
AbstractType, Type, TypeRef, TypeParameter, BoundedType, MixinAppType => Type?

https://codereview.chromium.org/3003903002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4094: DEFINE_ADD_VALUE_F_CID(Closure);
Maybe alias Context to Closure to blame context sizes againt closure?

https://codereview.chromium.org/3003903002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4098: for (int32_t id = kIntegerCid; id <= kBigintCid;
++id) {
intptr_t

[cbernaschina, 2017-08-28 23:19:27]

https://codereview.chromium.org/3003903002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/3003903002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4091: }
On 2017/08/28 22:51:08, rmacnak wrote:
> AbstractType, Type, TypeRef, TypeParameter, BoundedType, MixinAppType => Type?

Done.

https://codereview.chromium.org/3003903002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4094: DEFINE_ADD_VALUE_F_CID(Closure);
On 2017/08/28 22:51:08, rmacnak wrote:
> Maybe alias Context to Closure to blame context sizes againt closure?

Done.

https://codereview.chromium.org/3003903002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4098: for (int32_t id = kIntegerCid; id <= kBigintCid;
++id) {
On 2017/08/28 22:51:08, rmacnak wrote:
> intptr_t

Done.

[siva, 2017-08-28 23:31:16]

https://codereview.chromium.org/3003903002/diff/40001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/3003903002/diff/40001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4091: internals.AddValueF("classes/%" Pd,
static_cast<intptr_t>(id));
Is the static cast needed?

https://codereview.chromium.org/3003903002/diff/40001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4133: DEFINE_ADD_VALUE_F_CID(ByteBuffer)
Array and ImmutableArray also needs to be in this list?

[cbernaschina, 2017-08-28 23:36:17]

https://codereview.chromium.org/3003903002/diff/40001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/3003903002/diff/40001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4091: internals.AddValueF("classes/%" Pd,
static_cast<intptr_t>(id));
On 2017/08/28 23:31:16, siva wrote:
> Is the static cast needed?

enumerations are default converted to the smaller type that can contain it (int,
unsigned int, long, unsigned long, long long, or unsigned long long).
We use the cast to force it to a known type.

https://codereview.chromium.org/3003903002/diff/40001/runtime/vm/service.cc#n...
runtime/vm/service.cc:4133: DEFINE_ADD_VALUE_F_CID(ByteBuffer)
On 2017/08/28 23:31:16, siva wrote:
> Array and ImmutableArray also needs to be in this list?

They are listed via the CLASS_LIST_ARRAYS macro

[siva, 2017-08-29 01:17:42]

lgtm

[cbernaschina, 2017-08-29 01:19:00]

Description was changed from

==========
Hide internal classes from Memory Profile

The Service Protocol exposes a new private RPC _getDefaultClassesAliases
which returns a Map from internal classes to a String.

This Map is used to group internal classes and to avoid navigation to
patch files.
==========

to

==========
Hide internal classes from Memory Profile

The Service Protocol exposes a new private RPC _getDefaultClassesAliases
which returns a Map from internal classes to a String.

This Map is used to group internal classes and to avoid navigation to
patch files.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/89e72c7bb5aa7997cada71f806fed557b0fc08a6
==========

[cbernaschina, 2017-08-29 01:19:01]

Committed patchset #3 (id:40001) manually as
89e72c7bb5aa7997cada71f806fed557b0fc08a6 (presubmit successful).