runtime/observatory/tests/observatory_ui/mocks/objects/allocation_profile.dart - Issue 3003903002: Hide internal classes from Memory Profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/mocks/objects/allocation_profile.dart

Issue 3003903002: Hide internal classes from Memory Profile (Closed)

Patch Set: Address CL comments Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/observatory_ui/allocation_profile/element_test.dart ('k') | runtime/observatory/tests/observatory_ui/mocks/repositories/allocation_profile.dart » ('j') | runtime/vm/service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/mocks/objects/allocation_profile.dart

diff --git a/runtime/observatory/tests/observatory_ui/mocks/objects/allocation_profile.dart b/runtime/observatory/tests/observatory_ui/mocks/objects/allocation_profile.dart

index 7e90a5cc818f1a4f4e0a3f77b5d8a9666fc9439d..c61989eb2bc5767d8c73a78ec3bfc6483f888641 100644

--- a/runtime/observatory/tests/observatory_ui/mocks/objects/allocation_profile.dart

+++ b/runtime/observatory/tests/observatory_ui/mocks/objects/allocation_profile.dart

@@ -21,6 +21,7 @@ class AllocationProfileMock implements M.AllocationProfile {

class ClassHeapStatsMock implements M.ClassHeapStats {

final M.ClassRef clazz;

+ final String displayName;

final M.Allocations newSpace;

final M.Allocations oldSpace;

final int promotedInstances;

@@ -28,6 +29,7 @@ class ClassHeapStatsMock implements M.ClassHeapStats {

const ClassHeapStatsMock(

{this.clazz: const ClassRefMock(),

+ this.displayName: null,

this.newSpace: const AllocationsMock(),

this.oldSpace: const AllocationsMock(),

this.promotedInstances: 0,