Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: runtime/observatory/tests/observatory_ui/allocation_profile/element_test.dart

Issue 3003903002: Hide internal classes from Memory Profile (Closed)
Patch Set: Address CL comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/allocation_profile/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/allocation_profile/element_test.dart b/runtime/observatory/tests/observatory_ui/allocation_profile/element_test.dart
index 6fe8549bc0936fa7072c8e696f9ffab1d698b247..472bc70477be8a7f1c40b3c25c3740ba56de7492 100644
--- a/runtime/observatory/tests/observatory_ui/allocation_profile/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/allocation_profile/element_test.dart
@@ -31,10 +31,12 @@ main() {
test('elements created', () async {
final completer = new Completer<AllocationProfileMock>();
final repo = new AllocationProfileRepositoryMock(
- getter: expectAsync((M.IsolateRef i, bool gc, bool reset) {
+ getter:
+ expectAsync((M.IsolateRef i, bool gc, bool reset, bool combine) {
expect(i, equals(isolate));
expect(gc, isFalse);
expect(reset, isFalse);
+ expect(combine, isFalse);
return completer.future;
}, count: 1));
final e = new AllocationProfileElement(vm, isolate, events, notif, repo);
@@ -54,8 +56,10 @@ main() {
final completer = new Completer<AllocationProfileMock>();
int step = 0;
final repo = new AllocationProfileRepositoryMock(
- getter: expectAsync((M.IsolateRef i, bool gc, bool reset) {
+ getter:
+ expectAsync((M.IsolateRef i, bool gc, bool reset, bool combine) {
expect(i, equals(isolate));
+ expect(combine, isFalse);
switch (step) {
case 0:
expect(gc, isFalse);
@@ -95,10 +99,12 @@ main() {
final completer = new Completer<AllocationProfileMock>();
int count = 0;
final repo = new AllocationProfileRepositoryMock(
- getter: expectAsync((M.IsolateRef i, bool gc, bool reset) {
+ getter:
+ expectAsync((M.IsolateRef i, bool gc, bool reset, bool combine) {
expect(i, equals(isolate));
expect(gc, isFalse);
expect(reset, isFalse);
+ expect(combine, isFalse);
count++;
return completer.future;
}, count: 2));
@@ -144,10 +150,12 @@ main() {
]);
final completer = new Completer<AllocationProfileMock>();
final repo = new AllocationProfileRepositoryMock(
- getter: expectAsync((M.IsolateRef i, bool gc, bool reset) {
+ getter:
+ expectAsync((M.IsolateRef i, bool gc, bool reset, bool combine) {
expect(i, equals(isolate));
expect(gc, isFalse);
expect(reset, isFalse);
+ expect(combine, isFalse);
return completer.future;
}, count: 1));
final e = new AllocationProfileElement(vm, isolate, events, notif, repo);

Powered by Google App Engine
This is Rietveld 408576698