Split getClosureRepresentationInfo into MemberEntity and (ir/ast) nodes

Split getClosureRepresentationInfo into MemberEntity and (ir/ast) nodes

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/3c8096e040a7ce78f3737ef56a94119011143105

[Johnni Winther, 2017-08-18 13:56:48]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-08-18 21:04:43]

awesome! After the suggested changes below, lgtm!

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/closur...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:49: // TODO(johnniwinther,efortuna): Can we
use [getScopeInfo] instead?
you should be able to. In fact, getScopeInfo currently calls
getClosureRepresentationInfo if it's not in the first map.

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:50: ClosureRepresentationInfo
getMemberRepresentationInfo(MemberEntity member);
consider calling these:
getClosureInfoForMember
getClosureInfo
getClosureInfoForMemberTesting

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/closure.dart (right):

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:378: // TODO(johnniwinther,efortuna):
This is the only place we call
Hey Johnni, can you please clarify this comment? I don't understand what you're
suggesting we do in the future.

[Johnni Winther, 2017-08-19 08:28:28]

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/closur...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:49: // TODO(johnniwinther,efortuna): Can we
use [getScopeInfo] instead?
On 2017/08/18 21:04:43, Emily Fortuna wrote:
> you should be able to. In fact, getScopeInfo currently calls
> getClosureRepresentationInfo if it's not in the first map. 

Ok, I'll look into it.

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:50: ClosureRepresentationInfo
getMemberRepresentationInfo(MemberEntity member);
On 2017/08/18 21:04:43, Emily Fortuna wrote:
> consider calling these:
> getClosureInfoForMember
> getClosureInfo
> getClosureInfoForMemberTesting

Done.

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/closure.dart (right):

https://codereview.chromium.org/3002953002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:378: // TODO(johnniwinther,efortuna):
This is the only place we call
On 2017/08/18 21:04:43, Emily Fortuna wrote:
> Hey Johnni, can you please clarify this comment? I don't understand what
you're
> suggesting we do in the future.

If `closureSourceNode.parent` is an [ir.FunctionDeclaration] we should use the
local for its variable. If `closureSourceNode.parent` is an
[ir.FunctionExpression], we should create a fresh local.

[Johnni Winther, 2017-08-19 08:36:55]

Description was changed from

==========
Split getClosureRepresentationInfo into MemberEntity and (ir/ast) nodes
==========

to

==========
Split getClosureRepresentationInfo into MemberEntity and (ir/ast) nodes

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3c8096e040a7ce78f3737ef56a94119011143105
==========

[Johnni Winther, 2017-08-19 08:36:57]

Committed patchset #2 (id:20001) manually as
3c8096e040a7ce78f3737ef56a94119011143105 (presubmit successful).