Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 3002953002: Split getClosureRepresentationInfo into MemberEntity and (ir/ast) nodes (Closed)
Patch Set: Update cf. comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index 2da1e5811649290fd0459f5525fcb02b4d3595f5..5b2ffdcfeee3856ca139c759afdc649148926d2c 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -3067,9 +3067,8 @@ class KernelSsaGraphBuilder extends ir.Visitor
@override
visitFunctionNode(ir.FunctionNode node) {
- Local methodElement = localsMap.getLocalFunction(node.parent);
ClosureRepresentationInfo closureInfo =
- closureDataLookup.getClosureRepresentationInfo(methodElement);
+ localsMap.getClosureRepresentationInfo(closureDataLookup, node.parent);
ClassEntity closureClassEntity = closureInfo.closureClassEntity;
List<HInstruction> capturedVariables = <HInstruction>[];
@@ -3088,8 +3087,8 @@ class KernelSsaGraphBuilder extends ir.Visitor
visitFunctionDeclaration(ir.FunctionDeclaration declaration) {
assert(isReachable);
declaration.function.accept(this);
- Local localFunction = localsMap.getLocalFunction(declaration);
- localsHandler.updateLocal(localFunction, pop());
+ Local local = localsMap.getLocalVariable(declaration.variable);
+ localsHandler.updateLocal(local, pop());
}
@override
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698