Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 3002693002: Revert of [CacheStorage] Pad and bin opaque resource sizes. (Closed)

Created:
3 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 4 months ago
Reviewers:
jkarlin, cmumford
CC:
chromium-reviews, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, nhiroki
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [CacheStorage] Pad and bin opaque resource sizes. (patchset #11 id:200001 of https://codereview.chromium.org/2901083002/ ) Reason for revert: Crashes in these virtual test suites: * virtual/mojo-blobs/external/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https.html * virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/fetch-canvas-tainting-cache.https.html https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/3992 Original issue's description: > [CacheStorage] Pad and bin opaque resource sizes. > > BUG=617963 > > Review-Url: https://codereview.chromium.org/2901083002 > Cr-Commit-Position: refs/heads/master@{#494384} > Committed: https://chromium.googlesource.com/chromium/src/+/8421200aab24ddf59dfea7256ccffed8f7a61e0b TBR=jkarlin@chromium.org,cmumford@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617963 Review-Url: https://codereview.chromium.org/3002693002 Cr-Commit-Position: refs/heads/master@{#494428} Committed: https://chromium.googlesource.com/chromium/src/+/0ec1aed3b32089faaff776d4bfce69ea5f588314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -1008 lines) Patch
M content/browser/cache_storage/README.md View 2 chunks +1 line, -23 lines 0 comments Download
M content/browser/cache_storage/cache_storage.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/cache_storage/cache_storage.cc View 15 chunks +20 lines, -101 lines 0 comments Download
M content/browser/cache_storage/cache_storage.proto View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache.h View 13 chunks +10 lines, -68 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 32 chunks +112 lines, -345 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 11 chunks +23 lines, -150 lines 0 comments Download
M content/browser/cache_storage/cache_storage_index.h View 6 chunks +9 lines, -42 lines 0 comments Download
M content/browser/cache_storage/cache_storage_index.cc View 8 chunks +4 lines, -60 lines 0 comments Download
M content/browser/cache_storage/cache_storage_index_unittest.cc View 3 chunks +34 lines, -66 lines 0 comments Download
M content/browser/cache_storage/cache_storage_manager_unittest.cc View 5 chunks +13 lines, -143 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Reilly Grant (use Gerrit)
Created Revert of [CacheStorage] Pad and bin opaque resource sizes.
3 years, 4 months ago (2017-08-15 17:32:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3002693002/1
3 years, 4 months ago (2017-08-15 17:32:58 UTC) #3
commit-bot: I haz the power
3 years, 4 months ago (2017-08-15 17:34:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ec1aed3b32089faaff776d4bfce...

Powered by Google App Engine
This is Rietveld 408576698