Revert of [CacheStorage] Pad and bin opaque resource sizes.

content/browser/cache_storage/cache_storage_cache.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/cache_storage/cache_storage_cache.h"
 
 #include <stddef.h>
 #include <algorithm>
-#include <functional>
 #include <limits>
 #include <memory>
 #include <string>
 #include <utility>
 
 #include "base/barrier_closure.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_path.h"
 #include "base/guid.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "content/browser/cache_storage/cache_storage.pb.h"
 #include "content/browser/cache_storage/cache_storage_blob_to_disk_cache.h"
 #include "content/browser/cache_storage/cache_storage_cache_handle.h"
 #include "content/browser/cache_storage/cache_storage_cache_observer.h"
 #include "content/browser/cache_storage/cache_storage_scheduler.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/content_features.h"
 #include "content/public/common/referrer.h"
-#include "crypto/hmac.h"
-#include "crypto/symmetric_key.h"
 #include "net/base/completion_callback.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/disk_cache/disk_cache.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "services/network/public/interfaces/fetch_api.mojom.h"
 #include "storage/browser/blob/blob_data_builder.h"
 #include "storage/browser/blob/blob_data_handle.h"
 #include "storage/browser/blob/blob_impl.h"
 #include "storage/browser/blob/blob_storage_context.h"
@@ skipping 211 matching lines @@
       ProtoResponseTypeToFetchResponseType(metadata.response().response_type()),
       std::move(headers), "", 0, nullptr /* blob */,
       blink::kWebServiceWorkerResponseErrorUnknown,
       base::Time::FromInternalValue(metadata.response().response_time()),
       true /* is_in_cache_storage */, cache_name,
       base::MakeUnique<ServiceWorkerHeaderList>(
           metadata.response().cors_exposed_header_names().begin(),
           metadata.response().cors_exposed_header_names().end()));
 }
 
-// The size of opaque (non-cors) resource responses are padded in order
-// to obfuscate their actual size.
-bool ShouldPadResponseType(network::mojom::FetchResponseType response_type,
-                           bool has_urls) {
-  switch (response_type) {
-    case network::mojom::FetchResponseType::kBasic:
-    case network::mojom::FetchResponseType::kCORS:
-    case network::mojom::FetchResponseType::kDefault:
-    case network::mojom::FetchResponseType::kError:
-      return false;
-    case network::mojom::FetchResponseType::kOpaque:
-    case network::mojom::FetchResponseType::kOpaqueRedirect:
-      return has_urls;
-  }
-  NOTREACHED();
-  return false;
-}
-
-bool ShouldPadResourceSize(const content::proto::CacheResponse* response) {
-  return ShouldPadResponseType(
-      ProtoResponseTypeToFetchResponseType(response->response_type()),
-      response->url_list_size());
-}
-
-bool ShouldPadResourceSize(const ServiceWorkerResponse* response) {
-  return ShouldPadResponseType(response->response_type,
-                               !response->url_list.empty());
-}
-
-// If the way that a cache's padding is calculated changes increment this
-// version.
-//
-// History:
-//
-//   1: Uniform random 400K.
-const int32_t kCachePaddingAlgorithmVersion = 1;
-
-int64_t CalculateResponsePaddingInternal(
-    const std::string& response_url,
-    const crypto::SymmetricKey* padding_key,
-    int side_data_size) {
-  const uint64_t kPaddingRange = 400 * 1024;  // Increment version if changed.
-
-  DCHECK(!response_url.empty());
-
-  crypto::HMAC hmac(crypto::HMAC::SHA256);
-  if (!hmac.Init(padding_key))
-    LOG(FATAL) << "Failed to init HMAC.";
-
-  std::vector<uint8_t> digest(hmac.DigestLength());
-  bool success;
-  if (side_data_size)
-    success = hmac.Sign(response_url + "METADATA", &digest[0], digest.size());
-  else
-    success = hmac.Sign(response_url, &digest[0], digest.size());
-  if (!success)
-    LOG(FATAL) << "Failed to sign URL.";
-
-  DCHECK_GE(digest.size(), sizeof(uint64_t));
-  uint64_t val = *(reinterpret_cast<uint64_t*>(&digest[0]));
-  return val % kPaddingRange;
-}
-
-int64_t CalculateResponsePaddingInternal(
-    const ::content::proto::CacheResponse* response,
-    const crypto::SymmetricKey* padding_key,
-    int side_data_size) {
-  DCHECK(ShouldPadResourceSize(response));
-  const std::string& url = response->url_list(response->url_list_size() - 1);
-  return CalculateResponsePaddingInternal(url, padding_key, side_data_size);
-}
-
 }  // namespace
 
 // The state needed to pass between CacheStorageCache::Put callbacks.
 struct CacheStorageCache::PutContext {
   PutContext(std::unique_ptr<ServiceWorkerFetchRequest> request,
              std::unique_ptr<ServiceWorkerResponse> response,
              std::unique_ptr<storage::BlobDataHandle> blob_data_handle,
              CacheStorageCache::ErrorCallback callback)
       : request(std::move(request)),
         response(std::move(response)),
@@ skipping 17 matching lines @@
   std::unique_ptr<ServiceWorkerFetchRequest> request;
   std::unique_ptr<ServiceWorkerResponse> response;
   std::unique_ptr<storage::BlobDataHandle> blob_handle;
   disk_cache::ScopedEntryPtr entry;
   base::Time entry_time;
 };
 
 struct CacheStorageCache::QueryCacheContext {
   QueryCacheContext(std::unique_ptr<ServiceWorkerFetchRequest> request,
                     const CacheStorageCacheQueryParams& options,
-                    QueryCacheCallback callback,
-                    QueryTypes query_types)
+                    QueryCacheCallback callback)
       : request(std::move(request)),
         options(options),
         callback(std::move(callback)),
-        query_types(query_types),
         matches(base::MakeUnique<QueryCacheResults>()) {}
 
   ~QueryCacheContext() {
     // If the CacheStorageCache is deleted before a backend operation to open
     // an entry completes, the callback won't be run and the resulting entry
     // will be leaked unless we close it here.
     if (enumerated_entry) {
       enumerated_entry->Close();
       enumerated_entry = nullptr;
     }
   }
 
   // Input to QueryCache
   std::unique_ptr<ServiceWorkerFetchRequest> request;
   CacheStorageCacheQueryParams options;
   QueryCacheCallback callback;
-  QueryTypes query_types = 0;
+  QueryCacheType query_type;
   size_t estimated_out_bytes = 0;
 
   // Iteration state
   std::unique_ptr<disk_cache::Backend::Iterator> backend_iterator;
   disk_cache::Entry* enumerated_entry = nullptr;
 
   // Output of QueryCache
   std::unique_ptr<std::vector<QueryCacheResult>> matches;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(QueryCacheContext);
 };
 
 // static
 std::unique_ptr<CacheStorageCache> CacheStorageCache::CreateMemoryCache(
     const GURL& origin,
     const std::string& cache_name,
     CacheStorage* cache_storage,
     scoped_refptr<net::URLRequestContextGetter> request_context_getter,
     scoped_refptr<storage::QuotaManagerProxy> quota_manager_proxy,
-    base::WeakPtr<storage::BlobStorageContext> blob_context,
-    std::unique_ptr<crypto::SymmetricKey> cache_padding_key) {
+    base::WeakPtr<storage::BlobStorageContext> blob_context) {
   CacheStorageCache* cache = new CacheStorageCache(
       origin, cache_name, base::FilePath(), cache_storage,
       std::move(request_context_getter), std::move(quota_manager_proxy),
-      blob_context, 0 /* cache_size */, 0 /* cache_padding */,
-      std::move(cache_padding_key));
+      blob_context, 0 /* cache_size */);
   cache->SetObserver(cache_storage);
   cache->InitBackend();
   return base::WrapUnique(cache);
 }
 
 // static
 std::unique_ptr<CacheStorageCache> CacheStorageCache::CreatePersistentCache(
     const GURL& origin,
     const std::string& cache_name,
     CacheStorage* cache_storage,
     const base::FilePath& path,
     scoped_refptr<net::URLRequestContextGetter> request_context_getter,
     scoped_refptr<storage::QuotaManagerProxy> quota_manager_proxy,
     base::WeakPtr<storage::BlobStorageContext> blob_context,
-    int64_t cache_size,
-    int64_t cache_padding,
-    std::unique_ptr<crypto::SymmetricKey> cache_padding_key) {
+    int64_t cache_size) {
   CacheStorageCache* cache = new CacheStorageCache(
       origin, cache_name, path, cache_storage,
       std::move(request_context_getter), std::move(quota_manager_proxy),
-      blob_context, cache_size, cache_padding, std::move(cache_padding_key));
+      blob_context, cache_size);
   cache->SetObserver(cache_storage), cache->InitBackend();
   return base::WrapUnique(cache);
 }
 
 base::WeakPtr<CacheStorageCache> CacheStorageCache::AsWeakPtr() {
   return weak_ptr_factory_.GetWeakPtr();
 }
 
 void CacheStorageCache::Match(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
@@ skipping 225 matching lines @@
 }
 
 CacheStorageCache::CacheStorageCache(
     const GURL& origin,
     const std::string& cache_name,
     const base::FilePath& path,
     CacheStorage* cache_storage,
     scoped_refptr<net::URLRequestContextGetter> request_context_getter,
     scoped_refptr<storage::QuotaManagerProxy> quota_manager_proxy,
     base::WeakPtr<storage::BlobStorageContext> blob_context,
-    int64_t cache_size,
-    int64_t cache_padding,
-    std::unique_ptr<crypto::SymmetricKey> cache_padding_key)
+    int64_t cache_size)
     : origin_(origin),
       cache_name_(cache_name),
       path_(path),
       cache_storage_(cache_storage),
       request_context_getter_(std::move(request_context_getter)),
       quota_manager_proxy_(std::move(quota_manager_proxy)),
       blob_storage_context_(blob_context),
       scheduler_(
           new CacheStorageScheduler(CacheStorageSchedulerClient::CLIENT_CACHE)),
       cache_size_(cache_size),
-      cache_padding_(cache_padding),
-      cache_padding_key_(std::move(cache_padding_key)),
       max_query_size_bytes_(kMaxQueryCacheResultBytes),
       cache_observer_(nullptr),
       memory_only_(path.empty()),
       weak_ptr_factory_(this) {
   DCHECK(!origin_.is_empty());
   DCHECK(quota_manager_proxy_.get());
-  DCHECK(cache_padding_key_.get());
 
   quota_manager_proxy_->NotifyOriginInUse(origin_);
 }
 
 void CacheStorageCache::QueryCache(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& options,
-    QueryTypes query_types,
+    QueryCacheType query_type,
     QueryCacheCallback callback) {
-  DCHECK_NE(
-      QUERY_CACHE_ENTRIES | QUERY_CACHE_RESPONSES_WITH_BODIES,
-      query_types & (QUERY_CACHE_ENTRIES | QUERY_CACHE_RESPONSES_WITH_BODIES));
-  if (backend_state_ == BACKEND_CLOSED) {
+  DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
+  if (backend_state_ != BACKEND_OPEN) {
     std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE,
                             std::unique_ptr<QueryCacheResults>());
     return;
   }
 
   if (!options.ignore_method && request && !request->method.empty() &&
       request->method != "GET") {
     std::move(callback).Run(CACHE_STORAGE_OK,
                             base::MakeUnique<QueryCacheResults>());
     return;
   }
 
   ServiceWorkerFetchRequest* request_ptr = request.get();
-  std::unique_ptr<QueryCacheContext> query_cache_context(new QueryCacheContext(
-      std::move(request), options, std::move(callback), query_types));
+  std::unique_ptr<QueryCacheContext> query_cache_context(
+      new QueryCacheContext(std::move(request), options, std::move(callback)));
+  query_cache_context->query_type = query_type;
 
   if (query_cache_context->request &&
       !query_cache_context->request->url.is_empty() && !options.ignore_search) {
     // There is no need to scan the entire backend, just open the exact
     // URL.
     disk_cache::Entry** entry_ptr = &query_cache_context->enumerated_entry;
     net::CompletionCallback open_entry_callback =
         base::AdaptCallbackForRepeating(
             base::BindOnce(&CacheStorageCache::QueryCacheDidOpenFastPath,
                            weak_ptr_factory_.GetWeakPtr(),
@@ skipping 62 matching lines @@
   if (rv < 0) {
     std::move(query_cache_context->callback)
         .Run(CACHE_STORAGE_ERROR_STORAGE,
              std::move(query_cache_context->matches));
     return;
   }
 
   disk_cache::ScopedEntryPtr entry(query_cache_context->enumerated_entry);
   query_cache_context->enumerated_entry = nullptr;
 
-  if (backend_state_ == BACKEND_CLOSED) {
+  if (backend_state_ != BACKEND_OPEN) {
     std::move(query_cache_context->callback)
         .Run(CACHE_STORAGE_ERROR_NOT_FOUND,
              std::move(query_cache_context->matches));
     return;
   }
 
   if (query_cache_context->request &&
       !query_cache_context->request->url.is_empty()) {
     GURL requestURL = query_cache_context->request->url;
     GURL cachedURL = GURL(entry->GetKey());
@@ skipping 41 matching lines @@
 
   if (query_cache_context->request &&
       !query_cache_context->options.ignore_vary &&
       !VaryMatches(query_cache_context->request->headers,
                    match->request->headers, match->response->headers)) {
     query_cache_context->matches->pop_back();
     QueryCacheOpenNextEntry(std::move(query_cache_context));
     return;
   }
 
-  if (query_cache_context->query_types & QUERY_CACHE_ENTRIES)
+  if (query_cache_context->query_type == QueryCacheType::CACHE_ENTRIES) {
+    match->request.reset();
+    match->response.reset();
     match->entry = std::move(entry);
-
-  if (query_cache_context->query_types & QUERY_CACHE_REQUESTS) {
-    query_cache_context->estimated_out_bytes +=
-        match->request->EstimatedStructSize();
-    if (query_cache_context->estimated_out_bytes > max_query_size_bytes_) {
-      std::move(query_cache_context->callback)
-          .Run(CACHE_STORAGE_ERROR_QUERY_TOO_LARGE,
-               std::unique_ptr<QueryCacheResults>());
-      return;
-    }
-  } else {
-    match->request.reset();
+    QueryCacheOpenNextEntry(std::move(query_cache_context));
+    return;
   }
 
-  if (query_cache_context->query_types & QUERY_CACHE_RESPONSES_WITH_BODIES) {
-    query_cache_context->estimated_out_bytes +=
-        match->response->EstimatedStructSize();
-    if (query_cache_context->estimated_out_bytes > max_query_size_bytes_) {
-      std::move(query_cache_context->callback)
-          .Run(CACHE_STORAGE_ERROR_QUERY_TOO_LARGE,
-               std::unique_ptr<QueryCacheResults>());
-      return;
-    }
-    if (entry->GetDataSize(INDEX_RESPONSE_BODY) == 0) {
-      QueryCacheOpenNextEntry(std::move(query_cache_context));
-      return;
-    }
+  query_cache_context->estimated_out_bytes +=
+      match->request->EstimatedStructSize();
+  if (query_cache_context->estimated_out_bytes > max_query_size_bytes_) {
+    std::move(query_cache_context->callback)
+        .Run(CACHE_STORAGE_ERROR_QUERY_TOO_LARGE,
+             std::unique_ptr<QueryCacheResults>());
+    return;
+  }
 
-    if (!blob_storage_context_) {
-      std::move(query_cache_context->callback)
-          .Run(CACHE_STORAGE_ERROR_STORAGE,
-               std::unique_ptr<QueryCacheResults>());
-      return;
-    }
+  if (query_cache_context->query_type == QueryCacheType::REQUESTS) {
+    match->response.reset();
+    QueryCacheOpenNextEntry(std::move(query_cache_context));
+    return;
+  }
 
-    match->blob_handle =
-        PopulateResponseBody(std::move(entry), match->response.get());
-  } else if (!(query_cache_context->query_types &
-               QUERY_CACHE_RESPONSES_NO_BODIES)) {
-    match->response.reset();
+  DCHECK_EQ(QueryCacheType::REQUESTS_AND_RESPONSES,
+            query_cache_context->query_type);
+
+  query_cache_context->estimated_out_bytes +=
+      match->response->EstimatedStructSize();
+  if (query_cache_context->estimated_out_bytes > max_query_size_bytes_) {
+    std::move(query_cache_context->callback)
+        .Run(CACHE_STORAGE_ERROR_QUERY_TOO_LARGE,
+             std::unique_ptr<QueryCacheResults>());
+    return;
   }
 
+  if (entry->GetDataSize(INDEX_RESPONSE_BODY) == 0) {
+    QueryCacheOpenNextEntry(std::move(query_cache_context));
+    return;
+  }
+
+  if (!blob_storage_context_) {
+    std::move(query_cache_context->callback)
+        .Run(CACHE_STORAGE_ERROR_STORAGE,
+             base::MakeUnique<QueryCacheResults>());
+    return;
+  }
+
+  std::unique_ptr<storage::BlobDataHandle> blob_data_handle =
+      PopulateResponseBody(std::move(entry), match->response.get());
+  match->blob_handle = std::move(blob_data_handle);
+
   QueryCacheOpenNextEntry(std::move(query_cache_context));
 }
 
 // static
 bool CacheStorageCache::QueryCacheResultCompare(const QueryCacheResult& lhs,
                                                 const QueryCacheResult& rhs) {
   return lhs.entry_time < rhs.entry_time;
 }
 
-// static
-int64_t CacheStorageCache::CalculateResponsePadding(
-    const ServiceWorkerResponse& response,
-    const crypto::SymmetricKey* padding_key,
-    int side_data_size) {
-  if (!ShouldPadResourceSize(&response))
-    return 0;
-  return CalculateResponsePaddingInternal(response.url_list.back().spec(),
-                                          padding_key, side_data_size);
-}
-
-// static
-int32_t CacheStorageCache::GetResponsePaddingVersion() {
-  return kCachePaddingAlgorithmVersion;
-}
-
 void CacheStorageCache::MatchImpl(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& match_params,
     ResponseCallback callback) {
   MatchAllImpl(
       std::move(request), match_params,
       base::BindOnce(&CacheStorageCache::MatchDidMatchAll,
                      weak_ptr_factory_.GetWeakPtr(), std::move(callback)));
 }
 
@@ skipping 29 matching lines @@
     ResponsesCallback callback) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
     std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE,
                             std::unique_ptr<Responses>(),
                             std::unique_ptr<BlobDataHandles>());
     return;
   }
 
   QueryCache(
-      std::move(request), options,
-      QUERY_CACHE_REQUESTS | QUERY_CACHE_RESPONSES_WITH_BODIES,
+      std::move(request), options, QueryCacheType::REQUESTS_AND_RESPONSES,
       base::BindOnce(&CacheStorageCache::MatchAllDidQueryCache,
                      weak_ptr_factory_.GetWeakPtr(), std::move(callback)));
 }
 
 void CacheStorageCache::MatchAllDidQueryCache(
     ResponsesCallback callback,
     CacheStorageError error,
     std::unique_ptr<QueryCacheResults> query_cache_results) {
   if (error != CACHE_STORAGE_OK) {
     std::move(callback).Run(error, std::unique_ptr<Responses>(),
@@ skipping 92 matching lines @@
     std::unique_ptr<proto::CacheMetadata> headers) {
   if (!headers ||
       headers->response().response_time() !=
           expected_response_time.ToInternalValue()) {
     std::move(callback).Run(CACHE_STORAGE_ERROR_NOT_FOUND);
     return;
   }
   // Get a temporary copy of the entry pointer before passing it in base::Bind.
   disk_cache::Entry* temp_entry_ptr = entry.get();
 
-  std::unique_ptr<content::proto::CacheResponse> response(
-      headers->release_response());
-
-  int side_data_size_before_write = 0;
-  if (ShouldPadResourceSize(response.get()))
-    side_data_size_before_write = entry->GetDataSize(INDEX_SIDE_DATA);
-
   net::CompletionCallback write_side_data_callback =
       base::AdaptCallbackForRepeating(
           base::BindOnce(&CacheStorageCache::WriteSideDataDidWrite,
                          weak_ptr_factory_.GetWeakPtr(), std::move(callback),
-                         base::Passed(std::move(entry)), buf_len,
-                         std::move(response), side_data_size_before_write));
+                         base::Passed(std::move(entry)), buf_len));
 
   int rv = temp_entry_ptr->WriteData(
       INDEX_SIDE_DATA, 0 /* offset */, buffer.get(), buf_len,
       write_side_data_callback, true /* truncate */);
 
   if (rv != net::ERR_IO_PENDING)
     write_side_data_callback.Run(rv);
 }
 
-void CacheStorageCache::WriteSideDataDidWrite(
-    ErrorCallback callback,
-    disk_cache::ScopedEntryPtr entry,
-    int expected_bytes,
-    std::unique_ptr<::content::proto::CacheResponse> response,
-    int side_data_size_before_write,
-    int rv) {
+void CacheStorageCache::WriteSideDataDidWrite(ErrorCallback callback,
+                                              disk_cache::ScopedEntryPtr entry,
+                                              int expected_bytes,
+                                              int rv) {
   if (rv != expected_bytes) {
     entry->Doom();
     UpdateCacheSize(
         base::BindOnce(std::move(callback), CACHE_STORAGE_ERROR_NOT_FOUND));
     return;
   }
 
   if (rv > 0)
     storage::RecordBytesWritten(kRecordBytesLabel, rv);
 
-  if (ShouldPadResourceSize(response.get())) {
-    cache_padding_ -= CalculateResponsePaddingInternal(
-        response.get(), cache_padding_key_.get(), side_data_size_before_write);
-
-    cache_padding_ += CalculateResponsePaddingInternal(
-        response.get(), cache_padding_key_.get(), rv);
-  }
-
   UpdateCacheSize(base::BindOnce(std::move(callback), CACHE_STORAGE_OK));
 }
 
 void CacheStorageCache::Put(const CacheStorageBatchOperation& operation,
                             ErrorCallback callback) {
   DCHECK(BACKEND_OPEN == backend_state_ || initializing_);
   DCHECK_EQ(CACHE_STORAGE_CACHE_OPERATION_TYPE_PUT, operation.operation_type);
 
   std::unique_ptr<ServiceWorkerFetchRequest> request(
       new ServiceWorkerFetchRequest(
@@ skipping 34 matching lines @@
       base::Passed(std::move(put_context))));
 }
 
 void CacheStorageCache::PutImpl(std::unique_ptr<PutContext> put_context) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
     std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
-  // Explicitly delete the incumbent resource (which may not exist). This is
-  // only done so that it's padding will be decremented from the calculated
-  // cache padding.
-  // TODO(cmumford): Research alternatives to this explicit delete as it
-  // seriously impacts put performance.
-  auto delete_request = base::MakeUnique<ServiceWorkerFetchRequest>(
-      put_context->request->url, "", ServiceWorkerHeaderMap(), Referrer(),
-      false);
+  std::string key = put_context->request->url.spec();
 
-  CacheStorageCacheQueryParams query_options;
-  query_options.ignore_method = true;
-  query_options.ignore_vary = true;
-  DeleteImpl(std::move(delete_request), query_options,
-             base::BindOnce(&CacheStorageCache::PutDidDeleteEntry,
-                            weak_ptr_factory_.GetWeakPtr(),
-                            base::Passed(std::move(put_context))));
+  net::CompletionCallback callback =
+      base::AdaptCallbackForRepeating(base::BindOnce(
+          &CacheStorageCache::PutDidDoomEntry, weak_ptr_factory_.GetWeakPtr(),
+          base::Passed(std::move(put_context))));
+
+  int rv = backend_->DoomEntry(key, callback);
+  if (rv != net::ERR_IO_PENDING)
+    callback.Run(rv);
 }
 
-void CacheStorageCache::PutDidDeleteEntry(
-    std::unique_ptr<PutContext> put_context,
-    CacheStorageError error) {
+void CacheStorageCache::PutDidDoomEntry(std::unique_ptr<PutContext> put_context,
+                                        int rv) {
   if (backend_state_ != BACKEND_OPEN) {
     std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
-  if (error != CACHE_STORAGE_OK && error != CACHE_STORAGE_ERROR_NOT_FOUND) {
-    std::move(put_context->callback).Run(error);
-    return;
-  }
+  // |rv| is ignored as doom entry can fail if the entry doesn't exist.
 
   std::unique_ptr<disk_cache::Entry*> scoped_entry_ptr(
       new disk_cache::Entry*());
   disk_cache::Entry** entry_ptr = scoped_entry_ptr.get();
   ServiceWorkerFetchRequest* request_ptr = put_context->request.get();
   disk_cache::Backend* backend_ptr = backend_.get();
 
   net::CompletionCallback create_entry_callback =
       base::AdaptCallbackForRepeating(base::BindOnce(
           &CacheStorageCache::PutDidCreateEntry, weak_ptr_factory_.GetWeakPtr(),
           base::Passed(std::move(scoped_entry_ptr)),
           base::Passed(std::move(put_context))));
 
-  int rv = backend_ptr->CreateEntry(request_ptr->url.spec(), entry_ptr,
-                                    create_entry_callback);
+  int create_rv = backend_ptr->CreateEntry(request_ptr->url.spec(), entry_ptr,
+                                           create_entry_callback);
 
-  if (rv != net::ERR_IO_PENDING)
-    create_entry_callback.Run(rv);
+  if (create_rv != net::ERR_IO_PENDING)
+    create_entry_callback.Run(create_rv);
 }
 
 void CacheStorageCache::PutDidCreateEntry(
     std::unique_ptr<disk_cache::Entry*> entry_ptr,
     std::unique_ptr<PutContext> put_context,
     int rv) {
   put_context->cache_entry.reset(*entry_ptr);
 
   if (rv != net::OK) {
     std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_EXISTS);
@@ skipping 66 matching lines @@
     int expected_bytes,
     int rv) {
   if (rv != expected_bytes) {
     put_context->cache_entry->Doom();
     std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
   if (rv > 0)
     storage::RecordBytesWritten(kRecordBytesLabel, rv);
-  if (ShouldPadResourceSize(put_context->response.get())) {
-    cache_padding_ += CalculateResponsePadding(*put_context->response,
-                                               cache_padding_key_.get(),
-                                               0 /* side_data_size */);
-  }
 
   // The metadata is written, now for the response content. The data is streamed
   // from the blob into the cache entry.
 
   if (put_context->response->blob_uuid.empty()) {
     UpdateCacheSize(
         base::BindOnce(std::move(put_context->callback), CACHE_STORAGE_OK));
     return;
   }
 
@@ skipping 31 matching lines @@
   if (!success) {
     put_context->cache_entry->Doom();
     std::move(put_context->callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
   UpdateCacheSize(
       base::BindOnce(std::move(put_context->callback), CACHE_STORAGE_OK));
 }
 
-void CacheStorageCache::CalculateCacheSizePadding(
-    SizePaddingCallback got_sizes_callback) {
-  net::CompletionCallback got_size_callback =
-      base::AdaptCallbackForRepeating(base::BindOnce(
-          &CacheStorageCache::CalculateCacheSizePaddingGotSize,
-          weak_ptr_factory_.GetWeakPtr(), std::move(got_sizes_callback)));
-
-  int rv = backend_->CalculateSizeOfAllEntries(got_size_callback);
-  if (rv != net::ERR_IO_PENDING)
-    got_size_callback.Run(rv);
-}
-
-void CacheStorageCache::CalculateCacheSizePaddingGotSize(
-    SizePaddingCallback callback,
-    int cache_size) {
-  // Enumerating entries is only done during cache initialization and only if
-  // necessary.
-  DCHECK_EQ(backend_state_, BACKEND_UNINITIALIZED);
-  std::unique_ptr<ServiceWorkerFetchRequest> request;
-  CacheStorageCacheQueryParams options;
-  options.ignore_search = true;
-  QueryCache(std::move(request), options, QUERY_CACHE_RESPONSES_NO_BODIES,
-             base::BindOnce(&CacheStorageCache::PaddingDidQueryCache,
-                            weak_ptr_factory_.GetWeakPtr(), std::move(callback),
-                            cache_size));
-}
-
-void CacheStorageCache::PaddingDidQueryCache(
-    SizePaddingCallback callback,
-    int cache_size,
-    CacheStorageError error,
-    std::unique_ptr<QueryCacheResults> query_cache_results) {
-  int64_t cache_padding = 0;
-  if (error == CACHE_STORAGE_OK) {
-    for (const auto& result : *query_cache_results) {
-      if (ShouldPadResourceSize(result.response.get())) {
-        int32_t side_data_size =
-            result.entry ? result.entry->GetDataSize(INDEX_SIDE_DATA) : 0;
-        cache_padding += CalculateResponsePadding(
-            *result.response, cache_padding_key_.get(), side_data_size);
-      }
-    }
-  }
-
-  std::move(callback).Run(cache_size, cache_padding);
-}
-
-void CacheStorageCache::CalculateCacheSize(
-    const net::CompletionCallback& callback) {
-  int rv = backend_->CalculateSizeOfAllEntries(callback);
-  if (rv != net::ERR_IO_PENDING)
-    callback.Run(rv);
-}
-
 void CacheStorageCache::UpdateCacheSize(base::OnceClosure callback) {
   if (backend_state_ != BACKEND_OPEN)
     return;
 
   // Note that the callback holds a cache handle to keep the cache alive during
   // the operation since this UpdateCacheSize is often run after an operation
   // completes and runs its callback.
-  CalculateCacheSize(base::AdaptCallbackForRepeating(
+  net::CompletionCallback size_callback = base::AdaptCallbackForRepeating(
       base::BindOnce(&CacheStorageCache::UpdateCacheSizeGotSize,
                      weak_ptr_factory_.GetWeakPtr(),
-                     base::Passed(CreateCacheHandle()), std::move(callback))));
+                     base::Passed(CreateCacheHandle()), std::move(callback)));
+
+  int rv = backend_->CalculateSizeOfAllEntries(size_callback);
+  if (rv != net::ERR_IO_PENDING)
+    std::move(size_callback).Run(rv);
 }
 
 void CacheStorageCache::UpdateCacheSizeGotSize(
     std::unique_ptr<CacheStorageCacheHandle> cache_handle,
     base::OnceClosure callback,
     int current_cache_size) {
   DCHECK_NE(current_cache_size, CacheStorage::kSizeUnknown);
+  int64_t old_cache_size = cache_size_;
   cache_size_ = current_cache_size;
-  int64_t size_delta = PaddedCacheSize() - last_reported_size_;
-  last_reported_size_ = PaddedCacheSize();
+
+  int64_t size_delta = current_cache_size - old_cache_size;
 
   quota_manager_proxy_->NotifyStorageModified(
       storage::QuotaClient::kServiceWorkerCache, origin_,
       storage::kStorageTypeTemporary, size_delta);
 
   if (cache_observer_)
-    cache_observer_->CacheSizeUpdated(this);
+    cache_observer_->CacheSizeUpdated(this, current_cache_size);
 
   std::move(callback).Run();
 }
 
 void CacheStorageCache::Delete(const CacheStorageBatchOperation& operation,
                                ErrorCallback callback) {
   DCHECK(BACKEND_OPEN == backend_state_ || initializing_);
   DCHECK_EQ(CACHE_STORAGE_CACHE_OPERATION_TYPE_DELETE,
             operation.operation_type);
 
@@ skipping 13 matching lines @@
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& match_params,
     ErrorCallback callback) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
     std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE);
     return;
   }
 
   QueryCache(
-      std::move(request), match_params,
-      QUERY_CACHE_ENTRIES | QUERY_CACHE_RESPONSES_NO_BODIES,
+      std::move(request), match_params, QueryCacheType::CACHE_ENTRIES,
       base::BindOnce(&CacheStorageCache::DeleteDidQueryCache,
                      weak_ptr_factory_.GetWeakPtr(), std::move(callback)));
 }
 
 void CacheStorageCache::DeleteDidQueryCache(
     ErrorCallback callback,
     CacheStorageError error,
     std::unique_ptr<QueryCacheResults> query_cache_results) {
   if (error != CACHE_STORAGE_OK) {
     std::move(callback).Run(error);
     return;
   }
 
   if (query_cache_results->empty()) {
     std::move(callback).Run(CACHE_STORAGE_ERROR_NOT_FOUND);
     return;
   }
 
   for (auto& result : *query_cache_results) {
     disk_cache::ScopedEntryPtr entry = std::move(result.entry);
-    if (ShouldPadResourceSize(result.response.get())) {
-      cache_padding_ -=
-          CalculateResponsePadding(*result.response, cache_padding_key_.get(),
-                                   entry->GetDataSize(INDEX_SIDE_DATA));
-    }
     entry->Doom();
   }
 
   UpdateCacheSize(base::BindOnce(std::move(callback), CACHE_STORAGE_OK));
 }
 
 void CacheStorageCache::KeysImpl(
     std::unique_ptr<ServiceWorkerFetchRequest> request,
     const CacheStorageCacheQueryParams& options,
     RequestsCallback callback) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
   if (backend_state_ != BACKEND_OPEN) {
     std::move(callback).Run(CACHE_STORAGE_ERROR_STORAGE,
                             std::unique_ptr<Requests>());
     return;
   }
 
   QueryCache(
-      std::move(request), options, QUERY_CACHE_REQUESTS,
+      std::move(request), options, QueryCacheType::REQUESTS,
       base::BindOnce(&CacheStorageCache::KeysDidQueryCache,
                      weak_ptr_factory_.GetWeakPtr(), std::move(callback)));
 }
 
 void CacheStorageCache::KeysDidQueryCache(
     RequestsCallback callback,
     CacheStorageError error,
     std::unique_ptr<QueryCacheResults> query_cache_results) {
   if (error != CACHE_STORAGE_OK) {
     std::move(callback).Run(error, std::unique_ptr<Requests>());
@@ skipping 19 matching lines @@
   if (!post_backend_closed_callback_.is_null()) {
     DCHECK_NE(BACKEND_CLOSED, backend_state_);
     backend_state_ = BACKEND_CLOSED;
     std::move(post_backend_closed_callback_).Run();
   }
 }
 
 void CacheStorageCache::SizeImpl(SizeCallback callback) {
   DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
 
-  // TODO(cmumford): Can CacheStorage::kSizeUnknown be returned instead of zero?
-  if (backend_state_ != BACKEND_OPEN) {
-    base::ThreadTaskRunnerHandle::Get()->PostTask(
-        FROM_HERE, base::BindOnce(std::move(callback), 0));
-    return;
-  }
-
-  int64_t size = backend_state_ == BACKEND_OPEN ? PaddedCacheSize() : 0;
+  int64_t size = backend_state_ == BACKEND_OPEN ? cache_size_ : 0;
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::BindOnce(std::move(callback), size));
 }
 
 void CacheStorageCache::GetSizeThenCloseDidGetSize(SizeCallback callback,
                                                    int64_t cache_size) {
   CloseImpl(base::BindOnce(std::move(callback), cache_size));
 }
 
 void CacheStorageCache::CreateBackend(ErrorCallback callback) {
@@ skipping 52 matching lines @@
 }
 
 void CacheStorageCache::InitDidCreateBackend(
     base::OnceClosure callback,
     CacheStorageError cache_create_error) {
   if (cache_create_error != CACHE_STORAGE_OK) {
     InitGotCacheSize(std::move(callback), cache_create_error, 0);
     return;
   }
 
-  auto calculate_size_callback =
-      base::AdaptCallbackForRepeating(std::move(callback));
-  int rv = backend_->CalculateSizeOfAllEntries(base::Bind(
-      &CacheStorageCache::InitGotCacheSize, weak_ptr_factory_.GetWeakPtr(),
-      calculate_size_callback, cache_create_error));
+  net::CompletionCallback size_callback =
+      base::AdaptCallbackForRepeating(base::BindOnce(
+          &CacheStorageCache::InitGotCacheSize, weak_ptr_factory_.GetWeakPtr(),
+          std::move(callback), cache_create_error));
 
+  int rv = backend_->CalculateSizeOfAllEntries(size_callback);
   if (rv != net::ERR_IO_PENDING)
-    InitGotCacheSize(calculate_size_callback, cache_create_error, rv);
+    std::move(size_callback).Run(rv);
 }
 
 void CacheStorageCache::InitGotCacheSize(base::OnceClosure callback,
                                          CacheStorageError cache_create_error,
                                          int cache_size) {
   // Now that we know the cache size either 1) the cache size should be unknown
   // (which is why the size was calculated), or 2) it must match the current
   // size. If the sizes aren't equal then there is a bug in how the cache size
   // is saved in the store's index.
   if (cache_size_ != CacheStorage::kSizeUnknown) {
     DLOG_IF(ERROR, cache_size_ != cache_size)
         << "Cache size: " << cache_size
         << " does not match size from index: " << cache_size_;
     UMA_HISTOGRAM_COUNTS_10M("ServiceWorkerCache.IndexSizeDifference",
                              std::abs(cache_size_ - cache_size));
-    if (cache_size_ != cache_size) {
-      // We assume that if the sizes match then then cached padding is still
-      // correct. If not then we recalculate the padding.
-      CalculateCacheSizePaddingGotSize(
-          base::BindOnce(&CacheStorageCache::InitGotCacheSizeAndPadding,
-                         weak_ptr_factory_.GetWeakPtr(), std::move(callback),
-                         cache_create_error),
-          cache_size);
-      return;
-    }
+    // Disabled for crbug.com/681900.
+    // DCHECK_EQ(cache_size_, cache_size);
   }
-
-  if (cache_padding_ == CacheStorage::kSizeUnknown || cache_padding_ < 0) {
-    CalculateCacheSizePaddingGotSize(
-        base::BindOnce(&CacheStorageCache::InitGotCacheSizeAndPadding,
-                       weak_ptr_factory_.GetWeakPtr(), std::move(callback),
-                       cache_create_error),
-        cache_size);
-    return;
-  }
-
-  // If cached size matches actual size then assume cached padding is still
-  // correct.
-  InitGotCacheSizeAndPadding(std::move(callback), cache_create_error,
-                             cache_size, cache_padding_);
-}
-
-void CacheStorageCache::InitGotCacheSizeAndPadding(
-    base::OnceClosure callback,
-    CacheStorageError cache_create_error,
-    int64_t cache_size,
-    int64_t cache_padding) {
   cache_size_ = cache_size;
-  cache_padding_ = cache_padding;
-
   initializing_ = false;
   backend_state_ = (cache_create_error == CACHE_STORAGE_OK && backend_ &&
                     backend_state_ == BACKEND_UNINITIALIZED)
                        ? BACKEND_OPEN
                        : BACKEND_CLOSED;
 
   UMA_HISTOGRAM_ENUMERATION("ServiceWorkerCache.InitBackendResult",
                             cache_create_error, CACHE_STORAGE_ERROR_LAST + 1);
 
   if (cache_observer_)
-    cache_observer_->CacheSizeUpdated(this);
+    cache_observer_->CacheSizeUpdated(this, cache_size_);
 
   std::move(callback).Run();
 }
 
 std::unique_ptr<storage::BlobDataHandle>
 CacheStorageCache::PopulateResponseBody(disk_cache::ScopedEntryPtr entry,
                                         ServiceWorkerResponse* response) {
   DCHECK(blob_storage_context_);
 
   // Create a blob with the response body data.
@@ skipping 17 matching lines @@
   }
 
   return result;
 }
 
 std::unique_ptr<CacheStorageCacheHandle>
 CacheStorageCache::CreateCacheHandle() {
   return cache_storage_->CreateCacheHandle(this);
 }
 
-int64_t CacheStorageCache::PaddedCacheSize() const {
-  DCHECK_NE(BACKEND_UNINITIALIZED, backend_state_);
-  if (cache_size_ == CacheStorage::kSizeUnknown ||
-      cache_padding_ == CacheStorage::kSizeUnknown) {
-    return CacheStorage::kSizeUnknown;
-  }
-  return cache_size_ + cache_padding_;
-}
-
 }  // namespace content