src/hunspell/suggestmgr.cxx - Issue 300233002: [hunspell] Fix read from uninit memory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hunspell/suggestmgr.cxx

Issue 300233002: [hunspell] Fix read from uninit memory. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/hunspell.git@master

Patch Set: Updated instructions. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hunspell/suggestmgr.cxx

diff --git a/src/hunspell/suggestmgr.cxx b/src/hunspell/suggestmgr.cxx

index c3477df7af93583a5f3bf93c35628166410b9048..a3cebdf3d9c922233102974c3ccf389d9507e3a8 100644

--- a/src/hunspell/suggestmgr.cxx

+++ b/src/hunspell/suggestmgr.cxx

@@ -2108,16 +2108,14 @@ void SuggestMgr::lcs(const char * s, const char * s2, int * l1, int * l2, char *

m = strlen(s);

n = strlen(s2);

}

- c = (char *) malloc((m + 1) * (n + 1));

- b = (char *) malloc((m + 1) * (n + 1));

+ c = (char *) calloc((m + 1), (n + 1));

+ b = (char *) calloc((m + 1), (n + 1));

Avi (use Gerrit) 2014/05/27 20:40:49 The parentheses around m+1 and n+1 aren't necessar

if (!c || !b) {

if (c) free(c);

if (b) free(b);

*result = NULL;

return;

}

- for (i = 1; i <= m; i++) c[i*(n+1)] = 0;

- for (j = 0; j <= n; j++) c[j] = 0;

for (i = 1; i <= m; i++) {

for (j = 1; j <= n; j++) {

if ( ((utf8) && (*((short *) su+i-1) == *((short *)su2+j-1)))

« no previous file with comments | « google.patch ('k') | no next file » | no next file with comments »