Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 3001043002: [pinpoint] Add ReadGraphJsonValue. (Closed)

Created:
3 years, 4 months ago by dtu
Modified:
3 years, 4 months ago
Reviewers:
perezju, shatch, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[pinpoint] Add ReadGraphJsonValue. GTest perf tests output in a different format from ChartJson. Add support for reading the new format. This doesn't include hooking it up through QuestGenerator, which still needs some additional work. BUG=catapult:#3729 Review-Url: https://codereview.chromium.org/3001043002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6f4eaa933d94736ef58ed9e144ab86aec631adab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -22 lines) Patch
M dashboard/dashboard/pinpoint/models/quest/find_isolate.py View 2 chunks +6 lines, -6 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py View 7 chunks +13 lines, -7 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/quest/read_value.py View 1 chunk +34 lines, -0 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/quest/read_value_test.py View 1 chunk +22 lines, -0 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/quest_generator.py View 3 chunks +7 lines, -2 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/quest_generator_test.py View 8 chunks +11 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
dtu
3 years, 4 months ago (2017-08-16 22:09:21 UTC) #2
perezju
lgtm
3 years, 4 months ago (2017-08-17 08:00:19 UTC) #3
shatch
lgtm
3 years, 4 months ago (2017-08-17 11:44:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3001043002/1
3 years, 4 months ago (2017-08-17 15:20:10 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-17 15:46:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698