Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py

Issue 3001043002: [pinpoint] Add ReadGraphJsonValue. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py b/dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py
index 593956f49f036dc00cfd8810e26313f4f41b1b80..9625dc005e7447b7874f483250c872dc60083e36 100644
--- a/dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py
+++ b/dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py
@@ -60,7 +60,8 @@ class IsolateLookupTest(_FindIsolateTest):
def testIsolateLookupSuccess(self):
change = change_module.Change(change_module.Dep('src', 'f9f2b720'))
- execution = find_isolate.FindIsolate('Mac Pro Perf').Start(change)
+ quest = find_isolate.FindIsolate('Mac Pro Perf', 'telemetry_perf_tests')
+ execution = quest.Start(change)
execution.Poll()
self.assertExecutionSuccess(execution)
@@ -86,7 +87,8 @@ class BuilderLookupTest(_FindIsolateTest):
for builder, _ in builder_testers)
for builder, tester in builder_testers:
- execution = find_isolate.FindIsolate(tester).Start(change)
+ quest = find_isolate.FindIsolate(tester, 'telemetry_perf_tests')
+ execution = quest.Start(change)
execution.Poll()
self.assertExecutionSuccess(execution)
@@ -95,7 +97,7 @@ class BuilderLookupTest(_FindIsolateTest):
def testUnknownBuilder(self):
with self.assertRaises(NotImplementedError):
- find_isolate.FindIsolate('Unix Perf')
+ find_isolate.FindIsolate('Unix Perf', 'telemetry_perf_tests')
@mock.patch('dashboard.services.buildbucket_service.GetJobStatus')
@@ -107,7 +109,8 @@ class BuildTest(_FindIsolateTest):
change_module.Dep('src', 'base git hash'),
(change_module.Dep('v8', 'dep git hash'),),
patch=change_module.Patch('https://example.org', 2565263002, 20001))
- execution = find_isolate.FindIsolate('Mac Pro Perf').Start(change)
+ quest = find_isolate.FindIsolate('Mac Pro Perf', 'telemetry_perf_tests')
+ execution = quest.Start(change)
# Request a build.
put.return_value = {'build': {'id': 'build_id'}}
@@ -148,7 +151,8 @@ class BuildTest(_FindIsolateTest):
change_module.Dep('src', 'base git hash'),
(change_module.Dep('v8', 'dep git hash'),),
patch=change_module.Patch('https://example.org', 2565263002, 20001))
- execution = find_isolate.FindIsolate('Mac Pro Perf').Start(change)
+ quest = find_isolate.FindIsolate('Mac Pro Perf', 'telemetry_perf_tests')
+ execution = quest.Start(change)
# Request a build.
put.return_value = {'build': {'id': 'build_id'}}
@@ -171,7 +175,8 @@ class BuildTest(_FindIsolateTest):
change_module.Dep('src', 'base git hash'),
(change_module.Dep('v8', 'dep git hash'),),
patch=change_module.Patch('https://example.org', 2565263002, 20001))
- execution = find_isolate.FindIsolate('Mac Pro Perf').Start(change)
+ quest = find_isolate.FindIsolate('Mac Pro Perf', 'telemetry_perf_tests')
+ execution = quest.Start(change)
# Request a build.
put.return_value = {'build': {'id': 'build_id'}}
@@ -194,7 +199,8 @@ class BuildTest(_FindIsolateTest):
change_module.Dep('src', 'base git hash'),
(change_module.Dep('v8', 'dep git hash'),),
patch=change_module.Patch('https://example.org', 2565263002, 20001))
- execution = find_isolate.FindIsolate('Mac Pro Perf').Start(change)
+ quest = find_isolate.FindIsolate('Mac Pro Perf', 'telemetry_perf_tests')
+ execution = quest.Start(change)
# Request a build.
put.return_value = {'build': {'id': 'build_id'}}
« no previous file with comments | « dashboard/dashboard/pinpoint/models/quest/find_isolate.py ('k') | dashboard/dashboard/pinpoint/models/quest/read_value.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698