Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 3000813002: Reland of [devil] Extract logging common behavior to its own module. (Closed)

Created:
3 years, 4 months ago by jbudorick
Modified:
3 years, 4 months ago
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Reland of [devil] Extract logging common behavior to its own module. (patchset #1 id:1 of https://codereview.chromium.org/2998833002/ ) Reason for revert: Needs a src/-side change. Will manually handle the roll. Original issue's description: > Revert of [devil] Extract logging common behavior to its own module. (patchset #3 id:40001 of https://codereview.chromium.org/2972253002/ ) > > Reason for revert: > Appears to be blocking catapult roller. Tests are failing with, e.g.: > > Traceback (most recent call last): > File "/b/swarming/w/ir/build/android/test_runner.py", line 34, in <module> > from devil.utils import run_tests_helper > File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/run_tests_helper.py", line 10, in <module> > from devil.utils import logging_common > ImportError: cannot import name logging_common > [E2017-08-10T18:17:37.717840Z 31228 0 subcommand_run.go:333] Command completed with non-zero return code. {"returnCode":1} > [I2017-08-10T18:17:37.718115Z 31228 0 main.go:349] Terminating. {"returnCode":1} > > https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/240094 > > Original issue's description: > > [devil] Extract logging common behavior to its own module. > > > > Also deprecates the now-poorly-named run_tests_helper.py. > > > > Review-Url: https://codereview.chromium.org/2972253002 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/18709dd6bd88aee18994e1570754e0a1bb92bea4 > > TBR=mikecase@chromium.org,bpastene@chromium.org,jbudorick@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2998833002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f9ea41b51d8f6125b8283a2a2c4b610db431149c TBR=mikecase@chromium.org,bpastene@chromium.org,perezju@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/3000813002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b55e40d940682928f0942401aa78bb68d461abf7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -65 lines) Patch
M devil/devil/android/tools/adb_run_shell_cmd.py View 1 chunk +3 lines, -4 lines 0 comments Download
M devil/devil/android/tools/cpufreq.py View 3 chunks +3 lines, -5 lines 0 comments Download
M devil/devil/android/tools/device_recovery.py View 3 chunks +3 lines, -4 lines 0 comments Download
M devil/devil/android/tools/device_status.py View 3 chunks +3 lines, -4 lines 0 comments Download
M devil/devil/android/tools/flash_device.py View 2 chunks +3 lines, -4 lines 0 comments Download
M devil/devil/android/tools/keyboard.py View 2 chunks +3 lines, -3 lines 0 comments Download
M devil/devil/android/tools/provision_devices.py View 4 chunks +3 lines, -5 lines 0 comments Download
M devil/devil/android/tools/screenshot.py View 2 chunks +3 lines, -6 lines 0 comments Download
A devil/devil/utils/logging_common.py View 1 chunk +50 lines, -0 lines 0 comments Download
M devil/devil/utils/run_tests_helper.py View 2 chunks +9 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jbudorick
Created Reland of [devil] Extract logging common behavior to its own module.
3 years, 4 months ago (2017-08-11 17:39:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3000813002/1
3 years, 4 months ago (2017-08-11 17:40:08 UTC) #3
commit-bot: I haz the power
3 years, 4 months ago (2017-08-11 17:40:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698