Chromium Code Reviews
DescriptionReland of [devil] Extract logging common behavior to its own module. (patchset #1 id:1 of https://codereview.chromium.org/2998833002/ )
Reason for revert:
Needs a src/-side change. Will manually handle the roll.
Original issue's description:
> Revert of [devil] Extract logging common behavior to its own module. (patchset #3 id:40001 of https://codereview.chromium.org/2972253002/ )
>
> Reason for revert:
> Appears to be blocking catapult roller. Tests are failing with, e.g.:
>
> Traceback (most recent call last):
> File "/b/swarming/w/ir/build/android/test_runner.py", line 34, in <module>
> from devil.utils import run_tests_helper
> File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/run_tests_helper.py", line 10, in <module>
> from devil.utils import logging_common
> ImportError: cannot import name logging_common
> [E2017-08-10T18:17:37.717840Z 31228 0 subcommand_run.go:333] Command completed with non-zero return code. {"returnCode":1}
> [I2017-08-10T18:17:37.718115Z 31228 0 main.go:349] Terminating. {"returnCode":1}
>
> https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/240094
>
> Original issue's description:
> > [devil] Extract logging common behavior to its own module.
> >
> > Also deprecates the now-poorly-named run_tests_helper.py.
> >
> > Review-Url: https://codereview.chromium.org/2972253002
> > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/18709dd6bd88aee18994e1570754e0a1bb92bea4
>
> TBR=mikecase@chromium.org,bpastene@chromium.org,jbudorick@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2998833002
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f9ea41b51d8f6125b8283a2a2c4b610db431149c
TBR=mikecase@chromium.org,bpastene@chromium.org,perezju@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/3000813002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b55e40d940682928f0942401aa78bb68d461abf7
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||