Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 300002: Short-circuit events rwhvmac if it's focussed. (Closed)

Created:
11 years, 2 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, rohitrao (ping after 24h)
Visibility:
Public.

Description

Short-circuit events rwhvmac if it's focussed. This way the key view loop can't steal our events. This effectively reverts part of http://codereview.chromium.org/242069 and instead takes a bit from http://codereview.chromium.org/271054 . BUG=24921 TEST=Open 2 tabs. Focus web. Ctrl-tab should switch tabs. Cmd-1/2 should switch tabs. Hitting backspace should go back if no textbox is focusses in the web, else it should delete in the textbox. Hitting cmd-f in docs should still open docs custom search interface. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29396

Patch Set 1 #

Patch Set 2 : refine #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -38 lines) Patch
M chrome/browser/chrome_application_mac.mm View 2 chunks +24 lines, -0 lines 3 comments Download
M chrome/browser/cocoa/chrome_event_processing_window.mm View 1 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +4 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
I couldn't find a good way to hack around the key view event loop, and ...
11 years, 2 months ago (2009-10-19 05:29:49 UTC) #1
James Su
LGTM. Just wondering if it's necessary to send the unhandled key events back to |NSApp ...
11 years, 2 months ago (2009-10-19 09:35:01 UTC) #2
Avi (use Gerrit)
Sigh. If that's what works... LG
11 years, 2 months ago (2009-10-19 13:57:15 UTC) #3
pink (ping after 24hrs)
http://codereview.chromium.org/300002/diff/2001/3001 File chrome/browser/chrome_application_mac.mm (right): http://codereview.chromium.org/300002/diff/2001/3001#newcode193 Line 193: if ([event type] == NSKeyDown || [event type] ...
11 years, 2 months ago (2009-10-19 15:18:24 UTC) #4
Nico
http://codereview.chromium.org/300002/diff/2001/3001 File chrome/browser/chrome_application_mac.mm (right): http://codereview.chromium.org/300002/diff/2001/3001#newcode193 Line 193: if ([event type] == NSKeyDown || [event type] ...
11 years, 2 months ago (2009-10-19 20:06:43 UTC) #5
Mark Mentovai
11 years, 2 months ago (2009-10-22 20:44:36 UTC) #6
Startup time was infrequently over 300ms before this change, and now it's
infrequently UNDER 300ms.

Might not be this change, though.  It's hard to work out a precise window.

http://codereview.chromium.org/300002/diff/2001/3001
File chrome/browser/chrome_application_mac.mm (right):

http://codereview.chromium.org/300002/diff/2001/3001#newcode188
Line 188: - (void)sendEvent:(NSEvent*)event {
This change may have regressed startup time, but the regression was within the
range of jitter, so it's kind of hard to tell.

http://build.chromium.org/buildbot/perf/mac-release-10.5/startup/report.html?...

Powered by Google App Engine
This is Rietveld 408576698