Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 242069: Send key equivalents to renderer first. (Closed)

Created:
11 years, 2 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Send key equivalents to renderer first. Based on a patch by avi@. See also http://codereview.chromium.org/271054 . Known issues: * Breaks if any menu item ever uses a keyboard accelerator that doesn't use cmd as part of the flags. (* Suppressing keypress() doesn't prevent default action (suppressing keydown() works though. Both Firefox and Safari prevent the default action when either is suppressed). This seems to be broken on linux and windows too, though – it seems to match IE8, but not Firefox or Safari. I guess this is the question for the web council.) BUG=15090 TEST=Cmd-f now sucks when used on google docs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28709

Patch Set 1 #

Patch Set 2 : merge tot #

Patch Set 3 : kinda works #

Patch Set 4 : minor cleanup #

Patch Set 5 : tweak #

Patch Set 6 : remove some logging #

Patch Set 7 : cleanups #

Patch Set 8 : x #

Patch Set 9 : comments #

Patch Set 10 : 80col #

Patch Set 11 : ahem #

Total comments: 2

Patch Set 12 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +35 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 2 3 4 5 6 7 8 9 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
I see what you did here. I can live with that assumption. LG http://codereview.chromium.org/242069/diff/4002/5004 File ...
11 years, 2 months ago (2009-10-12 16:04:16 UTC) #1
Nico
11 years, 2 months ago (2009-10-12 16:17:57 UTC) #2
Thanks. Submitting, so that it gets into this week's dev channel release.

http://codereview.chromium.org/242069/diff/4002/5004
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/242069/diff/4002/5004#newcode541
Line 541: if ([[self window] firstResponder] != self)
On 2009/10/12 16:04:16, Avi wrote:
> This needs a comment, something about how pKE: is called on the entire view
> tree, not the first responder chain, so that we get called for events
unrelated
> to us (as this surprised me when I was playing with it).

Done.

Powered by Google App Engine
This is Rietveld 408576698