Short-circuit events rwhvmac if it's focussed.

chrome/browser/chrome_application_mac.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/chrome_application_mac.h"
 
 #import "base/histogram.h"
 #import "base/logging.h"
 #import "base/scoped_nsobject.h"
 #import "chrome/app/breakpad_mac.h"
+#import "chrome/browser/renderer_host/render_widget_host_view_mac.h"
 
 namespace CrApplicationNSException {
 
 // Maximum number of known named exceptions we'll support.  There is
 // no central registration, but I only find about 75 possibilities in
 // the system frameworks, and many of them are probably not
 // interesting to track in aggregate (those relating to distributed
 // objects, for instance).
 const size_t kKnownNSExceptionCount = 25;
 
@@ skipping 156 matching lines @@
 
   NSString* actionString = NSStringFromSelector(anAction);
   NSString* value =
         [NSString stringWithFormat:@"%@ tag %d sending %@ to %p",
                   [sender className], tag, actionString, aTarget];
 
   ScopedCrashKey key(kActionKey, value);
   return [super sendAction:anAction to:aTarget from:sender];
 }
 
+- (void)sendEvent:(NSEvent*)event {

[Mark Mentovai, 2009/10/22 20:44:36]

This change may have regressed startup time, but the regression was within the
range of jitter, so it's kind of hard to tell.

http://build.chromium.org/buildbot/perf/mac-release-10.5/startup/report.html?...

+  // The superclass's |sendEvent:| sends keyboard events to the menu and the key
+  // view loop before dispatching them to |keyDown:|. Since we want to send keys
+  // to the renderer before sending them to the menu, and we never want them to
+  // the kev view loop when the web is focussed, we change this behavior.
+  if ([event type] == NSKeyDown || [event type] == NSKeyUp) {

[pink (ping after 24hrs), 2009/10/19 15:18:24]

I really dislike the app controller having this kind of knowledge. Makes it hard
to change the impl classes under the hood. Can you at least move this chunk into
BrowserWindowController and have it do the checks and dispatch? It's more
sensical to me that the browser knows about RWHVC's.

[Nico, 2009/10/19 20:06:43]

I'm addressing this comment (and more) in http://codereview.chromium.org/303002
.

+    if ([[[self keyWindow] firstResponder]
+        isKindOfClass:[RenderWidgetHostViewCocoa class]]) {
+      // No other mac browser sends keyup() for keyboard equivalents, so let's
+      // suppress this.
+      if (([event modifierFlags] & NSCommandKeyMask) && [event type] == NSKeyUp)
+        return;
+
+      RenderWidgetHostViewCocoa* rwhv = static_cast<RenderWidgetHostViewCocoa*>(
+          [[self keyWindow] firstResponder]);
+      [rwhv keyEvent:event];
+      return;
+    }
+  }
+
+  [super sendEvent:event];
+}
+
 // NSExceptions which are caught by the event loop are logged here.
 // NSException uses setjmp/longjmp, which can be very bad for C++, so
 // we attempt to track and report them.
 - (void)reportException:(NSException *)anException {
   // If we throw an exception in this code, we can create an infinite
   // loop.  If we throw out of the if() without resetting
   // |reportException|, we'll stop reporting exceptions for this run.
   static BOOL reportingException = NO;
   DCHECK(!reportingException);
   if (!reportingException) {
@@ skipping 36 matching lines @@
 
 @end
 
 namespace CrApplicationCC {
 
 void Terminate() {
   [NSApp terminate:nil];
 }
 
 }  // namespace CrApplicationCC